This is an archive of the discontinued LLVM Phabricator instance.

[LLDB] Make API tests to run using MSYS tools
ClosedPublic

Authored by omjavaid on Aug 31 2022, 1:18 AM.

Details

Summary

MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also
MSYS 'pwd' returns non-windows path string.
This patch fixes Makefile.rules to make adjustments required to run LLDB
API tests using MSYS tools.

Diff Detail

Event Timeline

omjavaid created this revision.Aug 31 2022, 1:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 1:18 AM
omjavaid requested review of this revision.Aug 31 2022, 1:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2022, 1:18 AM
mstorsjo accepted this revision.Aug 31 2022, 3:47 AM

LGTM, this looks reasonable to me.

This revision is now accepted and ready to land.Aug 31 2022, 3:47 AM
labath accepted this revision.Aug 31 2022, 5:47 AM

Seems reasonable. BTW, these days, I don't think anybody is invoking make directly from the command line, so it would be fine (maybe even desirable) to move some of this logic into python code -- particularly if it makes windows compatibility easier.

This revision was automatically updated to reflect the committed changes.