[LLDB] Make API tests to run using MSYS tools

[omjavaid]

Summary

MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also
MSYS 'pwd' returns non-windows path string.
This patch fixes Makefile.rules to make adjustments required to run LLDB
API tests using MSYS tools.

[mstorsjo]

LGTM, this looks reasonable to me.

[labath]

Seems reasonable. BTW, these days, I don't think anybody is invoking make directly from the command line, so it would be fine (maybe even desirable) to move some of this logic into python code -- particularly if it makes windows compatibility easier.

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

 # without specifying a goal. You almost certainly want to build 'all',
 # and not only the first target defined in this file (which might vary
 # according to variable values).
 .DEFAULT_GOAL := all
 
 #----------------------------------------------------------------------
 # If OS is not defined, use 'uname -s' to determine the OS name.
 #
-# uname on Windows gives "windows32" or "server version windows32", but most
-# environments standardize on "Windows_NT", so we'll make it consistent here.
+# GNUWin32 uname gives "windows32" or "server version windows32" while
+# some versions of MSYS uname return "MSYS_NT*", but most environments
+# standardize on "Windows_NT", so we'll make it consistent here. 
 # When running tests from Visual Studio, the environment variable isn't
 # inherited all the way down to the process spawned for make.
 #----------------------------------------------------------------------
 HOST_OS := $(shell uname -s)
 ifneq (,$(findstring windows32,$(HOST_OS)))
   HOST_OS := Windows_NT
 endif
+
+ifneq (,$(findstring MSYS_NT,$(HOST_OS)))
+  HOST_OS := Windows_NT
+endif
+
 ifeq "$(OS)" ""
   OS := $(HOST_OS)
 endif
 
 #----------------------------------------------------------------------
 # If OS is Windows, force SHELL to be cmd
 #
 # Some versions of make on Windows will search for other shells such as
 # C:\cygwin\bin\sh.exe. This shell fails for numerous different reasons
 # so default to using cmd.exe.
+# Also reset BUILDDIR value because "pwd" returns cygwin or msys path
+# which needs to be converted to windows path.
 #----------------------------------------------------------------------
 ifeq "$(OS)" "Windows_NT"
   SHELL = $(WINDIR)\system32\cmd.exe
+  BUILDDIR := $(shell echo %cd%)
 endif
 
 #----------------------------------------------------------------------
 # If the OS is Windows use double-quotes in commands
 #
 # For other operating systems, single-quotes work fine, but on Windows
 # we strictly required double-quotes
 #----------------------------------------------------------------------