This is an archive of the discontinued LLVM Phabricator instance.

Remove unnecessary `REQUIRES: x86-registered-target` from ps4/ps5 driver tests.
ClosedPublic

Authored by MaggieYi on Aug 30 2022, 8:41 AM.

Details

Summary

Some PS4/PS45 tests include the line REQUIRES: x86-registered-target meaning they depend on having the X86 backend included in the build. This should not be necessary since the driver understands all triples regardless of which backends are included.

The change removes all unnecessary REQUIRES: x86-registered-target from ps4/ps5 driver tests.

Diff Detail

Event Timeline

MaggieYi created this revision.Aug 30 2022, 8:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:41 AM
Herald added a subscriber: pengfei. · View Herald Transcript
MaggieYi requested review of this revision.Aug 30 2022, 8:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:41 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
probinson accepted this revision.Aug 30 2022, 8:59 AM

LGTM. Checking the tests over by eye, it looks like all run the clang driver with -### or -E so only the driver itself is invoked, and no backend dependency exists.

This revision is now accepted and ready to land.Aug 30 2022, 8:59 AM

Thanks Paul.