This is an archive of the discontinued LLVM Phabricator instance.

Differential D132948

[SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++)
ClosedPublic

Authored by muiez on Aug 30 2022, 8:12 AM.

Details

Reviewers
fanbo-meng
zibi
ldionne
Group Reviewers
Restricted Project
Commits
rG1b445cada51e: [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++)
Summary

This patch fixes the z/OS build by using the first implementation of __remove_all since we don't have access to the openat() family of POSIX functions.

Diff Detail

Event Timeline

muiez created this revision.Aug 30 2022, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:12 AM
muiez requested review of this revision.Aug 30 2022, 8:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 30 2022, 8:12 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
fanbo-meng accepted this revision.Aug 30 2022, 8:14 AM

LGTM

muiez retitled this revision from [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR for z/OS (libc++) to [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++).Aug 30 2022, 8:15 AM
zibi accepted this revision.Aug 30 2022, 8:31 AM

LGTM

Harbormaster completed remote builds in B184171: Diff 456681.Aug 30 2022, 11:39 AM
muiez added a comment.Sep 8 2022, 11:53 AM

@libc++ may I get a review please?

ldionne accepted this revision.Sep 15 2022, 1:00 PM
This revision is now accepted and ready to land.Sep 15 2022, 1:00 PM
Closed by commit rG1b445cada51e: [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++) (authored by muiez). · Explain WhySep 16 2022, 7:23 AM
This revision was automatically updated to reflect the committed changes.
muiez added a commit: rG1b445cada51e: [SystemZ][z/OS] define REMOVE_ALL_USE_DIRECTORY_ITERATOR (libc++).

Revision Contents

PathSize
libcxx/
src/
filesystem/
2 lines

Diff 456681

libcxx/src/filesystem/operations.cpp

Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
// We currently have two implementations of `__remove_all`. The first one is general and // We currently have two implementations of `__remove_all`. The first one is general and
// used on platforms where we don't have access to the `openat()` family of POSIX functions. // used on platforms where we don't have access to the `openat()` family of POSIX functions.
// That implementation uses `directory_iterator`, however it is vulnerable to some race // That implementation uses `directory_iterator`, however it is vulnerable to some race
// conditions, see https://reviews.llvm.org/D118134 for details. // conditions, see https://reviews.llvm.org/D118134 for details.
// //
// The second implementation is used on platforms where `openat()` & friends are available, // The second implementation is used on platforms where `openat()` & friends are available,
// and it threads file descriptors through recursive calls to avoid such race conditions. // and it threads file descriptors through recursive calls to avoid such race conditions.
#if defined(_LIBCPP_WIN32API) #if defined(_LIBCPP_WIN32API) || defined (__MVS__)
# define REMOVE_ALL_USE_DIRECTORY_ITERATOR # define REMOVE_ALL_USE_DIRECTORY_ITERATOR
#endif #endif
#if defined(REMOVE_ALL_USE_DIRECTORY_ITERATOR) #if defined(REMOVE_ALL_USE_DIRECTORY_ITERATOR)
namespace { namespace {
uintmax_t remove_all_impl(path const& p, error_code& ec) { uintmax_t remove_all_impl(path const& p, error_code& ec) {
▲ Show 20 Lines • Show All 743 Lines • Show Last 20 Lines