This is an archive of the discontinued LLVM Phabricator instance.

Differential D132902

[CMake][MLGO] Fix cmake for MLGO
ClosedPublic

Authored by eopXD on Aug 29 2022, 6:17 PM.

Details

Reviewers
mtrofin
Commits
rGea3630e8d4df: [CMake][MLGO] Fix cmake for MLGO
Summary

The if-statement should check whehter TFLITE is on or not rather than if the variable is specified.

Diff Detail

Event Timeline

eopXD created this revision.Aug 29 2022, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 6:17 PM
Herald added subscribers: hiraditya, mgorny. · View Herald Transcript
eopXD requested review of this revision.Aug 29 2022, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 6:17 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
eopXD retitled this revision from [CMake] Fix cmake for MLGO to [CMake][MLGO] Fix cmake for MLGO.Aug 29 2022, 6:17 PM
eopXD added a reviewer: mtrofin.
Harbormaster completed remote builds in B184049: Diff 456511.Aug 29 2022, 7:13 PM
mtrofin accepted this revision.Aug 29 2022, 8:19 PM

Lgtm, thanks!

This revision is now accepted and ready to land.Aug 29 2022, 8:19 PM
Closed by commit rGea3630e8d4df: [CMake][MLGO] Fix cmake for MLGO (authored by eopXD). · Explain WhySep 6 2022, 12:32 AM
This revision was automatically updated to reflect the committed changes.
eopXD added a commit: rGea3630e8d4df: [CMake][MLGO] Fix cmake for MLGO.

Revision Contents

PathSize
llvm/
lib/
Analysis/
2 lines

Diff 458111

llvm/lib/Analysis/CMakeLists.txt

Show All 12 Lines tf_find_and_compile(
serve serve
action action
InlinerSizeModel InlinerSizeModel
llvm::InlinerSizeModel llvm::InlinerSizeModel
) )
endif() endif()
if (DEFINED LLVM_HAVE_TF_API) if (DEFINED LLVM_HAVE_TF_API)
if (DEFINED LLVM_HAVE_TFLITE) if (LLVM_HAVE_TFLITE)
build_proto( build_proto(
tensorflow/core/protobuf/error_codes tensorflow/core/protobuf/error_codes
tensorflow/core/example/feature tensorflow/core/example/feature
tensorflow/core/example/example) tensorflow/core/example/example)
list(APPEND MLLinkDeps list(APPEND MLLinkDeps
tensorflow-lite::tensorflow-lite tensorflow-lite::tensorflow-lite
protobuf::libprotobuf) protobuf::libprotobuf)
else() else()
▲ Show 20 Lines • Show All 146 Lines • Show Last 20 Lines