This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][CostModel][NFC] Specify target datalayout explicitly for cost analysis test.
ClosedPublic

Authored by mingmingl on Aug 29 2022, 2:31 PM.

Details

Summary
  • Use linux little endian data layout string for all files (linux and eabi).
  • Files with arm64-apple-ios (select.ll and logicalop.ll) sets target datalayout already. They are not modified in this patch.

Diff Detail

Event Timeline

mingmingl created this revision.Aug 29 2022, 2:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 2:32 PM
mingmingl requested review of this revision.Aug 29 2022, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 2:32 PM
mingmingl updated this revision to Diff 456468.Aug 29 2022, 2:58 PM

add back IR 'target' for two tests that were mistakenly removed in previous diff.

mingmingl edited the summary of this revision. (Show Details)
mingmingl added reviewers: fhahn, dmgreen.

Found 59 files without "datalayout" by "grep -rL "datalayout" llvm/test/Analysis/CostModel/AArch64/ | sort " in a branch without this patch, and "git diff HEAD^1 --name-only | sort" in this patch gives the same set of files (except "llvm/test/Analysis/CostModel/AArch64/lit.local.cfg")

dmgreen accepted this revision.Aug 31 2022, 1:22 AM

Thanks. LGTM

This revision is now accepted and ready to land.Aug 31 2022, 1:22 AM
This revision was landed with ongoing or failed builds.Aug 31 2022, 9:53 AM
This revision was automatically updated to reflect the committed changes.