Page MenuHomePhabricator

[libc++][test] Use TEST_HAS_NO_CHAR8_T to simplify #ifdefs. NFCI.
ClosedPublic

Authored by jloser on Aug 24 2022, 5:59 PM.

Details

Summary

Many tests in libcxx/test/std/strings use `#if defined(cpp_lib_char8_t) &&
cpp_lib_char8_t >= 201811L` which can be replaced with the more terse `#ifndef
TEST_HAS_NO_CHAR8_T`.

Diff Detail

Event Timeline

jloser created this revision.Aug 24 2022, 5:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 5:59 PM
jloser requested review of this revision.Aug 24 2022, 5:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 5:59 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript

Interesting I thought I had already done this :-/
Thanks for the cleanup! LGTM!

Mordante accepted this revision.Aug 25 2022, 9:12 AM

(Or you select the accept option ;-) )

This revision is now accepted and ready to land.Aug 25 2022, 9:12 AM