This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Tests transitive includes for all C++ versions.
ClosedPublic

Authored by Mordante on Aug 23 2022, 11:03 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG3d68a67fe671: [libc++] Tests transitive includes for all C++ versions.
Summary

D132284 has an approach to reduce the number of transitive includes
based on the language version used. This requires to be able to validate
changes in transitive includes in all language versions.

Due to issues in the experimental library c++03 will be done separately.

Diff Detail

Event Timeline

Mordante created this revision.Aug 23 2022, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 11:03 PM
ldionne published this revision for review.Aug 24 2022, 9:00 AM
ldionne added a subscriber: ldionne.

LGTM assuming 100% similarity between the old expected headers and the new ones in cxx2b/.

libcxx/test/libcxx/transitive_includes.sh.cpp
53–54
61–62

Don't forget this!

Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 9:00 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 24 2022, 9:01 AM
This revision is now accepted and ready to land.Aug 24 2022, 9:01 AM
ldionne added inline comments.Aug 24 2022, 9:03 AM
libcxx/test/libcxx/transitive_includes.sh.cpp
23–24

In a follow-up, we can guard the parts of experimental that don't work in C++03 with #ifndef _LIBCPP_CXX03_LANG.

Mordante marked 3 inline comments as done.Aug 24 2022, 10:17 AM

Thanks for the review.

Mordante edited the summary of this revision. (Show Details)Aug 24 2022, 10:18 AM
This revision was landed with ongoing or failed builds.Aug 24 2022, 10:23 AM
This revision was automatically updated to reflect the committed changes.