[lldb-cmake] Turn Debug Info test failures into pipeline errors

[Michael137]

Summary

Currently the "Debug Info" tests fail but that is not reflected
in the pipeline. We do a set +e before we run the tests to
overide the default Jenkins shell's set -e; this hides the
test failures. Remove this for now and see if fixing the test
failures will be enough to make this pipeline stage consistent
with the behaviour of the other stages.

[fdeazeve]

LGTM! I suspect we'll discover why these were added once we merge this :)

[Michael137]

Reverting for now because test failures in this stage will prevent the non-debug-info tests from running (which is default Jenkins pipeline behaviour). Will try to mimic the lldb-cmake-matrix bot which sets tests that failed to "unstable"

[aprantl]

In D132391#3740297, @Michael137 wrote:

Reverting for now because test failures in this stage will prevent the non-debug-info tests from running (which is default Jenkins pipeline behaviour). Will try to mimic the lldb-cmake-matrix bot which sets tests that failed to "unstable"

Sounds good!

zorg/jenkins/jobs/jobs/lldb-cmake

stages {
             steps {
                 timeout(30) {
                     sh '''
                     set -u
                     export PATH=$PATH:/usr/bin:/usr/local/bin
 
                     export MAX_PARALLEL_TESTS=$(sysctl hw.physicalcpu |awk '{print $2}')
 
-                    set +e
                     python llvm-zorg/zorg/jenkins/monorepo_build.py lldb-cmake-debuginfo test
-                    set -e
                     '''
                 }
             }
         }
         stage('Test (LLDB)') {
             steps {
                 timeout(90) {
                     sh '''