Details
Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project - Commits
- rG640e2bae5090: [libc++] Mark everything in <deque> as _LIBCPP_HIDE_FROM_ABI and replace…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
I only skimmed the file and see no direct oddities.
But this patch is an ABI break on multiple platforms.
Comment Actions
It's not an ABI break. I added that test in the parent commit and didn't get the numbers right yet.
Comment Actions
It wasn't clear from this patch that it was put on top of a "broken" patch. It would have been nice to add that as a hint for the reviewers.
Comment Actions
I don't expect new patches on top of patches that don't compile, since that makes them fail too.
But the patch needs to be rebased anyway after the lower patch works again/is landed so will look at it then.