This is an archive of the discontinued LLVM Phabricator instance.

[Flang] Mark 128 float MODULO intrinsic calls as "TODO"
ClosedPublic

Authored by PeteSteinfeld on Aug 17 2022, 4:56 PM.

Details

Summary

The code generated for this version of the intrinsic is broken. I'm
marking it as a "TODO" for now so that people don't get unannounce bad
results.

Diff Detail

Event Timeline

PeteSteinfeld created this revision.Aug 17 2022, 4:56 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 17 2022, 4:56 PM
Herald added a subscriber: mehdi_amini. · View Herald Transcript
PeteSteinfeld requested review of this revision.Aug 17 2022, 4:56 PM

I suggest changing the format of the message to something like

intrinsic: MODULO (kind 16)

to more closely match other intrinsic call TODO messages.

Responding to Val's comments.

Here's a sample of a message that the current code produces:

error: loc("./vx2b.f90":12:5): /local/home/psteinfeld/up/llvm-project/flang/lib/Lower/IntrinsicCall.cpp:3481: not yet implemented: intrinsic: MODULO for floating point of KIND=16

vdonaldson accepted this revision.Aug 17 2022, 10:00 PM
This revision is now accepted and ready to land.Aug 17 2022, 10:00 PM