Page MenuHomePhabricator

[libc++] Replace _LIBCPP_INLINE_VISIBILITY and mark all functions _LIBCPP_HIDE_FROM_ABI in __split_buffer
ClosedPublic

Authored by philnik on Aug 17 2022, 7:36 AM.

Diff Detail

Event Timeline

philnik created this revision.Aug 17 2022, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2022, 7:36 AM
philnik requested review of this revision.Aug 17 2022, 7:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2022, 7:36 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
huixie90 accepted this revision as: huixie90.Aug 17 2022, 12:47 PM

LGTM

libcxx/include/__split_buffer
45–46

Not an issue. At the first glance, I was wondering why these two were not marked as hidden from abi. then I realised that there are no implementations and these are just CXX03 way of making it non-copyable.

philnik added inline comments.Aug 17 2022, 12:48 PM
libcxx/include/__split_buffer
45–46

Yeah, I should continue the work on D121213.

ldionne accepted this revision.Aug 18 2022, 9:23 AM
This revision is now accepted and ready to land.Aug 18 2022, 9:23 AM