This is an archive of the discontinued LLVM Phabricator instance.

[mlir][shape] add value_of op
ClosedPublic

Authored by yaochengji on Aug 16 2022, 9:43 AM.

Diff Detail

Event Timeline

yaochengji created this revision.Aug 16 2022, 9:43 AM
yaochengji requested review of this revision.Aug 16 2022, 9:43 AM
jpienaar accepted this revision.Aug 16 2022, 2:59 PM

Thanks, makes sense to have the peer function. Just some doc updates here.

mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
647

It need not be a tensor.

One could also mention this is the peer of shape_of.

648

I think lets add here and to ShapeOfOp that behavior is UB if input is error.

This revision is now accepted and ready to land.Aug 16 2022, 2:59 PM

update the description

yaochengji marked 2 inline comments as done.Aug 16 2022, 4:41 PM
This revision was automatically updated to reflect the committed changes.