Page MenuHomePhabricator

yaochengji (Chengji Yao)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 18 2020, 6:06 AM (129 w, 16 h)

Recent Activity

Oct 3 2022

yaochengji added a comment to D131810: [mlir][shape] add outline-shape-computation pass.

Thanks @jpienaar and @csigg

Oct 3 2022, 12:01 PM · Restricted Project, Restricted Project

Sep 30 2022

yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.

format code

Sep 30 2022, 10:20 AM · Restricted Project, Restricted Project
yaochengji added inline comments to D131810: [mlir][shape] add outline-shape-computation pass.
Sep 30 2022, 12:01 AM · Restricted Project, Restricted Project

Sep 29 2022

yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.
Sep 29 2022, 11:56 PM · Restricted Project, Restricted Project
yaochengji added a comment to D131810: [mlir][shape] add outline-shape-computation pass.

[seems I didn't send my last reply of "Sorry fell off review queue while I was out.", I get confused with all the review systems when which one sends what comments]

Sep 29 2022, 11:21 AM · Restricted Project, Restricted Project

Sep 27 2022

yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.

populate shape mapping information into Analysis instead and add two required tests.

Sep 27 2022, 4:46 PM · Restricted Project, Restricted Project

Aug 30 2022

yaochengji added inline comments to D131810: [mlir][shape] add outline-shape-computation pass.
Aug 30 2022, 11:38 PM · Restricted Project, Restricted Project

Aug 26 2022

yaochengji added inline comments to D131810: [mlir][shape] add outline-shape-computation pass.
Aug 26 2022, 4:45 PM · Restricted Project, Restricted Project
yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.
Aug 26 2022, 4:45 PM · Restricted Project, Restricted Project

Aug 22 2022

yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.

rebase on new main branch

Aug 22 2022, 5:00 PM · Restricted Project, Restricted Project
yaochengji added a comment to D131810: [mlir][shape] add outline-shape-computation pass.

Note that this diff should be finalized after https://reviews.llvm.org/D131977 is merged.

Aug 22 2022, 11:49 AM · Restricted Project, Restricted Project
yaochengji updated the diff for D131810: [mlir][shape] add outline-shape-computation pass.

misc fixes

Aug 22 2022, 11:40 AM · Restricted Project, Restricted Project

Aug 20 2022

yaochengji updated the diff for D131977: [mlir][shape] refine shape.func and shape.with_shape.

Thanks for pointing this out, use getSymNameAttrName and getFunctionTypeAttrName instead

Aug 20 2022, 9:48 AM · Restricted Project, Restricted Project

Aug 16 2022

yaochengji updated the diff for D131976: [mlir][shape] add value_of op.

update the description

Aug 16 2022, 4:40 PM · Restricted Project, Restricted Project
yaochengji requested review of D131977: [mlir][shape] refine shape.func and shape.with_shape.
Aug 16 2022, 9:51 AM · Restricted Project, Restricted Project
yaochengji requested review of D131976: [mlir][shape] add value_of op.
Aug 16 2022, 9:43 AM · Restricted Project, Restricted Project

Aug 12 2022

yaochengji updated the summary of D131810: [mlir][shape] add outline-shape-computation pass.
Aug 12 2022, 2:44 PM · Restricted Project, Restricted Project
yaochengji requested review of D131810: [mlir][shape] add outline-shape-computation pass.
Aug 12 2022, 2:42 PM · Restricted Project, Restricted Project
yaochengji accepted D131497: [mlir][shape] Add dim op.
Aug 12 2022, 10:15 AM · Restricted Project, Restricted Project

Aug 10 2022

yaochengji added inline comments to D131497: [mlir][shape] Add dim op.
Aug 10 2022, 11:01 AM · Restricted Project, Restricted Project

Aug 9 2022

yaochengji requested changes to D131497: [mlir][shape] Add dim op.

Could you add test in ops.mlir for this new op?

Aug 9 2022, 5:52 PM · Restricted Project, Restricted Project

Aug 8 2022

yaochengji accepted D130866: [mlir][shape] Update meet to handle all size & shape types.

LGTM to me after the CI passes.

Aug 8 2022, 10:58 PM · Restricted Project, Restricted Project

Aug 7 2022

yaochengji added inline comments to D130866: [mlir][shape] Update meet to handle all size & shape types.
Aug 7 2022, 8:21 AM · Restricted Project, Restricted Project

May 16 2022

yaochengji added a comment to D125676: [mlir] Fix endian conversion of sub-byte types.

Thanks @uweigand for fixing this.

May 16 2022, 11:57 AM · Restricted Project, Restricted Project

May 6 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Looks like this new test case fails on s390x, causing the build bot to go red:
https://lab.llvm.org/buildbot/#/builders/199/builds/5139

May 6 2022, 10:50 AM · Restricted Project, Restricted Project

May 5 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

What email do you want this commit to be attributed to?

May 5 2022, 4:42 PM · Restricted Project, Restricted Project
yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

There seems no responds from @rriddle .

May 5 2022, 4:20 PM · Restricted Project, Restricted Project

Apr 25 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Hi @rriddle , could it be merged?

Apr 25 2022, 12:07 PM · Restricted Project, Restricted Project

Apr 12 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

@rriddle , it's added, thanks.

Apr 12 2022, 11:09 AM · Restricted Project, Restricted Project

Apr 11 2022

yaochengji updated the summary of D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.
Apr 11 2022, 10:30 AM · Restricted Project, Restricted Project
yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Can you a bit more detail to the description describing what the underlying problem was?

Apr 11 2022, 10:22 AM · Restricted Project, Restricted Project

Apr 8 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

@rriddle I've added the test case, could you take a look at it?

Apr 8 2022, 10:35 AM · Restricted Project, Restricted Project

Apr 4 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Even just an empty module with an appropriate attribute?

Apr 4 2022, 11:25 AM · Restricted Project, Restricted Project

Apr 1 2022

yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Thanks everyone for your suggestion. I've added a new test case.

Apr 1 2022, 6:46 PM · Restricted Project, Restricted Project
yaochengji updated the diff for D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.
Apr 1 2022, 6:45 PM · Restricted Project, Restricted Project
yaochengji updated the diff for D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.
Apr 1 2022, 6:39 PM · Restricted Project, Restricted Project
yaochengji updated the diff for D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.
Apr 1 2022, 11:30 AM · Restricted Project, Restricted Project
yaochengji added a comment to D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.

Can you add a test case?

Apr 1 2022, 11:23 AM · Restricted Project, Restricted Project
yaochengji requested review of D122925: [mlir] Fix printer when it is a DenseElementsAttr of i1.
Apr 1 2022, 11:14 AM · Restricted Project, Restricted Project

Jun 14 2021

yaochengji updated the diff for D103782: fix DRR's optional operand support.

change nullptr to Value()

Jun 14 2021, 11:48 AM · Restricted Project
yaochengji added inline comments to D103782: fix DRR's optional operand support.
Jun 14 2021, 10:49 AM · Restricted Project
yaochengji updated the diff for D103782: fix DRR's optional operand support.

add an unittest and update summary.

Jun 14 2021, 10:35 AM · Restricted Project

Jun 12 2021

yaochengji added inline comments to D103782: fix DRR's optional operand support.
Jun 12 2021, 8:09 AM · Restricted Project

Jun 6 2021

yaochengji updated the summary of D103782: fix DRR's optional operand support.
Jun 6 2021, 6:55 PM · Restricted Project
yaochengji updated the summary of D103782: fix DRR's optional operand support.
Jun 6 2021, 6:52 PM · Restricted Project
yaochengji requested review of D103782: fix DRR's optional operand support.
Jun 6 2021, 6:50 PM · Restricted Project

Dec 26 2020

yaochengji requested review of D93831: fix affine_map compose with multi-symbols.
Dec 26 2020, 11:37 PM · Restricted Project