This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomptarget] Fix run region async condition
ClosedPublic

Authored by kevinsala on Aug 12 2022, 8:07 AM.

Details

Summary

This patch fixes a condition in the openmp/libomptarget/src/device.cpp file. The code was checking if the run_region plugin API function was implemented, but it should actually check the run_region_async function instead.

Diff Detail

Event Timeline

kevinsala created this revision.Aug 12 2022, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 8:07 AM
kevinsala requested review of this revision.Aug 12 2022, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 8:07 AM
This revision is now accepted and ready to land.Aug 12 2022, 8:17 AM

Hi Shilei Tian,
I don't have access to push commits to the LLVM repository. Would you mind pushing this fix commit for me?
Thank you in advance

Hi Shilei Tian,
I don't have access to push commits to the LLVM repository. Would you mind pushing this fix commit for me?
Thank you in advance

Sure. What's your GitHub email?

My GitHub account has linked the following email: ksalapenades@anl.gov

Thank you