[LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

[DavidSpickett]

Summary

https://reviews.llvm.org/D131658 identified a bug in this and
turns out it's not used anywhere.

[DavidSpickett]

@JDevlieghere Unless this is still used in your downstream?

[DavidSpickett]

Thanks for the review folks. I'll just wait for Jonas to confirm (probably not used downstream but no rush to land this).

[DavidSpickett]

@JDevlieghere ping!

[JDevlieghere]

In D131664#3715513, @DavidSpickett wrote:

@JDevlieghere Unless this is still used in your downstream?

Thanks for checking. It's not used downstream, so this LGTM.

lldb/source/Plugins/Instruction/ARM/EmulationStateARM.h

public:
   bool StoreToPseudoAddress(lldb::addr_t p_address, uint32_t value);
 
   uint32_t ReadFromPseudoAddress(lldb::addr_t p_address, bool &success);
 
   void ClearPseudoRegisters();
 
   void ClearPseudoMemory();
 
-  bool LoadPseudoRegistersFromFrame(lldb_private::StackFrame &frame);
-
   bool LoadStateFromDictionary(lldb_private::OptionValueDictionary *test_data);
 
   bool CompareState(EmulationStateARM &other_state,
                     lldb_private::Stream *out_stream);
 
   static size_t
   ReadPseudoMemory(lldb_private::EmulateInstruction *instruction, void *baton,
                    const lldb_private::EmulateInstruction::Context &context,

lldb/source/Plugins/Instruction/ARM/EmulationStateARM.cpp

 using namespace lldb_private;
 
 EmulationStateARM::EmulationStateARM() : m_vfp_regs(), m_memory() {
   ClearPseudoRegisters();
 }
 
 EmulationStateARM::~EmulationStateARM() = default;
 
-bool EmulationStateARM::LoadPseudoRegistersFromFrame(StackFrame &frame) {
-  RegisterContext *reg_ctx = frame.GetRegisterContext().get();
-  bool success = true;
-  uint32_t reg_num;
-
-  for (int i = dwarf_r0; i < dwarf_r0 + 17; ++i) {
-    reg_num =
-        reg_ctx->ConvertRegisterKindToRegisterNumber(eRegisterKindDWARF, i);
-    const RegisterInfo *reg_info = reg_ctx->GetRegisterInfoAtIndex(reg_num);
-    RegisterValue reg_value;
-    if (reg_ctx->ReadRegister(reg_info, reg_value)) {
-      m_gpr[i - dwarf_r0] = reg_value.GetAsUInt32();
-    } else
-      success = false;
-  }
-
-  for (int i = dwarf_d0; i < dwarf_d0 + 32; ++i) {
-    reg_num =
-        reg_ctx->ConvertRegisterKindToRegisterNumber(eRegisterKindDWARF, i);
-    RegisterValue reg_value;
-    const RegisterInfo *reg_info = reg_ctx->GetRegisterInfoAtIndex(reg_num);
-
-    if (reg_ctx->ReadRegister(reg_info, reg_value)) {
-      uint64_t value = reg_value.GetAsUInt64();
-      uint32_t idx = i - dwarf_d0;
-      if (idx < 16) {
-        m_vfp_regs.s_regs[idx * 2] = (uint32_t)value;
-        m_vfp_regs.s_regs[idx * 2 + 1] = (uint32_t)(value >> 32);
-      } else
-        m_vfp_regs.d_regs[idx - 16] = value;
-    } else
-      success = false;
-  }
-
-  return success;
-}
-
 bool EmulationStateARM::StorePseudoRegisterValue(uint32_t reg_num,
                                                  uint64_t value) {
   if (reg_num <= dwarf_cpsr)
     m_gpr[reg_num - dwarf_r0] = (uint32_t)value;
   else if ((dwarf_s0 <= reg_num) && (reg_num <= dwarf_s31)) {
     uint32_t idx = reg_num - dwarf_s0;
     m_vfp_regs.s_regs[idx] = (uint32_t)value;
   } else if ((dwarf_d0 <= reg_num) && (reg_num <= dwarf_d31)) {