This is an archive of the discontinued LLVM Phabricator instance.

[EarlyCSE] allow flexibility in atan(-0.0) test
ClosedPublic

Authored by spatel on Aug 10 2022, 10:52 AM.

Details

Summary

As discussed in the post-commit feedback for b53d44fe47413c87f619b, this test was failing on AIX because atan(-0.0) results in 0.0 (positive).
I don't have an AIX system to test this pre-commit, so posting for review in case we can check that first.

Diff Detail

Event Timeline

spatel created this revision.Aug 10 2022, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:52 AM
Herald added a subscriber: mcrosier. · View Herald Transcript
spatel requested review of this revision.Aug 10 2022, 10:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:52 AM
Jake-Egan accepted this revision.Aug 10 2022, 11:59 AM

Verified that it passes on AIX. LGTM.

This revision is now accepted and ready to land.Aug 10 2022, 11:59 AM
This revision was landed with ongoing or failed builds.Aug 10 2022, 12:04 PM
This revision was automatically updated to reflect the committed changes.