This is an archive of the discontinued LLVM Phabricator instance.

[update_llc_test_checks][VE] Add baseline test for PIC function regex
ClosedPublic

Authored by arichardson on Aug 8 2022, 1:24 PM.

Details

Summary

While working on https://reviews.llvm.org/D131429, I got a test diff in
one of the VE tests and running update_llc_test_checks.py deleted all the
code for that function. This is a baseline test for this bug (incorrect
regex for VE when .Lfoo$local symbols are used).

Diff Detail

Event Timeline

arichardson created this revision.Aug 8 2022, 1:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:24 PM
arichardson published this revision for review.Aug 8 2022, 1:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 8 2022, 1:31 PM
kaz7 added a comment.Aug 10 2022, 5:31 AM

This patch itself looks fine although I'm not sure what the point of this patch is.

kaz7 accepted this revision.Aug 10 2022, 4:37 PM

Maybe the purpose of this patch is related to D131431. LGTM.

This revision is now accepted and ready to land.Aug 10 2022, 4:37 PM
This revision was landed with ongoing or failed builds.Aug 24 2022, 7:17 AM
This revision was automatically updated to reflect the committed changes.