[builtins] Build both static and shared versions of the builtins library.

[vkalintiris]

lib/builtins/CMakeLists.txt

343

Why do we use the C99 standard explicitly here? I would like to change that and use whatever is the compiler's default or make it a user defined option. At least for MIPS, this would allow us to include atomic.c in builtins, when using C11.

[vkalintiris]

Ping.

[samsonov]

Do you have a proper support (i.e. Clang driver logic, and compiler flag) for using clang_rt.builtins shared runtime? Or for now you just somehow link with shared compiler-rt runtime manually?

[rengolin]

What's the motivation behind this? I'm not saying I'm against it, just want to understand the scope and objectives, and make sure we can support (and test) all configurations.

[vkalintiris]

In D13139#260666, @rengolin wrote:

What's the motivation behind this? I'm not saying I'm against it, just want to understand the scope and objectives, and make sure we can support (and test) all configurations.

I just thought that it would be an alternative for libgcc_s for toolchains that don't depend on a GCC installation. Currently, I'm not aware of any Clang toolchain that can use this shared library. I'd like to add support for using the shared build of the builtins library by the mips-mti-linux (D13340) toolchain in the next few weeks. Would it be better to wait until then?

[samsonov]

Yes, let's postpone this patch until Clang is able to properly use this shared library, and we have means to test it.

lib/builtins/CMakeLists.txt

if (CAN_TARGET_${arch})
       foreach (_file ${${arch}_SOURCES})
         if (${_file} MATCHES ${arch}/*)
           get_filename_component(_name ${_file} NAME)
           string(REPLACE ".S" ".c" _cname "${_name}")
           list(REMOVE_ITEM ${arch}_SOURCES ${_cname})
         endif ()
       endforeach ()
 
+      foreach (build_type STATIC SHARED)
         add_compiler_rt_runtime(clang_rt.builtins
-                              STATIC
+                                ${build_type}
                                 ARCHS ${arch}
                                 SOURCES ${${arch}_SOURCES}
                                 CFLAGS "-std=c99"
                                 PARENT_TARGET builtins)
+      endforeach()
     endif ()
   endforeach ()
 endif ()
 
 add_dependencies(compiler-rt builtins)