This is an archive of the discontinued LLVM Phabricator instance.

[llvm][Demangle] Add getter for FunctionEncoding::Attrs
AcceptedPublic

Authored by Michael137 on Aug 6 2022, 10:40 AM.

Details

Reviewers
aprantl
urnathan
ldionne
Group Reviewers
Restricted Project
Summary

In LLDB we use the Itanium mangle tree API to compare
function encodings of mangled names when selecting a
candidate symbol for expression evaluation. We now
also include ABI tags in this comparison. This patch
makes this possible by exposing the Attrs in the mangle
tree API.

Diff Detail

Event Timeline

Michael137 created this revision.Aug 6 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2022, 10:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2022, 10:49 AM
aprantl accepted this revision.Aug 8 2022, 8:42 AM
This revision is now accepted and ready to land.Aug 8 2022, 8:42 AM

@urnathan @ldionne any idea who is responsible for mirroring this change in libcxxabi?

@urnathan @ldionne any idea who is responsible for mirroring this change in libcxxabi?

It's actually the other way around! According to libcxxabi/src/demangle/README.txt, the change should be done in libcxxabi/src/demangle and then libcxxabi/src/demangle/cp-to-llvm.sh can be used to mirror. Note that changing libcxxabi will also have the effect of triggering libc++abi's CI pipeline, which in turn should have at least some coverage for the demangler changes.

  • Sync with libcxxabi
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2022, 6:06 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
This revision now requires review to proceed.Aug 12 2022, 6:06 AM
urnathan accepted this revision.Aug 16 2022, 12:22 PM
This revision is now accepted and ready to land.Aug 16 2022, 12:22 PM