Page MenuHomePhabricator

[CMake] Fix runtimes cross-compilation when using LLVM_USE_LINKER
ClosedPublic

Authored by thevinster on Aug 3 2022, 12:00 AM.

Details

Summary

This is motivated by https://reviews.llvm.org/D115852#3226050 where passing
LLVM_USE_LINKER in PASSTHROUGH_PREFIXES breaks cross-compilation
(e.g. targeting Windows on a Linux host). As suggested on that diff, implement
an override for it by allowing users to pass RUNTIMES_${target}_LLVM_USE_LINKER
to specify the linker for runtimes. Defaults to host linker if not specified.

Diff Detail

Event Timeline

thevinster created this revision.Aug 3 2022, 12:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 12:00 AM
Herald added a subscriber: mgorny. · View Herald Transcript
thevinster edited the summary of this revision. (Show Details)Aug 3 2022, 12:05 AM
thevinster added reviewers: phosek, smeenai.
thevinster published this revision for review.Aug 3 2022, 12:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 12:07 AM
phosek accepted this revision.Aug 3 2022, 12:13 AM

LGTM

This revision is now accepted and ready to land.Aug 3 2022, 12:13 AM
smeenai accepted this revision.Aug 3 2022, 10:39 AM

LGTM

This revision was landed with ongoing or failed builds.Aug 3 2022, 11:24 AM
This revision was automatically updated to reflect the committed changes.