[lldb/crashlog] Remove 'process_path' parsing logic

[mib]

Summary

In can happen when creating stackshot crash report that that key is missing.

Moreover, we try to parse that key but don't use it, or need it, since we
fetch images and symbolicate the stackframes using the binaries UUIDs.

This is why this patch removes everything that is related to the
process_path/procPath parsing.

rdar://95054188

Signed-off-by: Med Ismail Bennani <[e-mail]>

[aprantl]

Could we test this by removing the key from an existing testcase?

lldb/examples/python/crashlog.py

474

Is it now undefined if it doesn't exist? Does that cause an exception when we try to access it?
Is there anything special about procPath, or should all the JSON keys be optional like this?
i.e., is there a json_data.readOrDefault(key, default_value) method?

[kastiglione]

lldb/examples/python/crashlog.py

473–474

another way of doing this is:

self.crashlog.process_path = json_data.get('procPath')

get() returns None if the key doesn't exist.

[mib]

lldb/examples/python/crashlog.py

474

process_path is actually not used in crashlog.py at all. Since it can be missing in some crash reports, we need to parse it only when it's available, otherwise we get the following error which causes the crashlog script to stop:

error: python exception: Failed to parse JSON crashlog: KeyError: 'procPath'

[mib]

Remove procPath key from crash report for testing

[JDevlieghere]

lldb/examples/python/crashlog.py

474

If it's not used, should we just remove it altogether?

[mib]

lldb/examples/python/crashlog.py

474

Sure! Since we symbolicate the crashlogs by fetching the used binaries UUIDs, I think it's reasonable to get rid of everything related the procPath

[mib]

Remove the process_path parsing logic

[JDevlieghere]

Ship it

lldb/examples/python/crashlog.py

def parse(self):
 
         return self.crashlog
 
     def get_used_image(self, idx):
         return self.data['usedImages'][idx]
 
     def parse_process_info(self, json_data):
         self.crashlog.process_id = json_data['pid']
         self.crashlog.process_identifier = json_data['procName']
-        self.crashlog.process_path = json_data['procPath']
 
     def parse_crash_reason(self, json_exception):
         exception_type = json_exception['type']
         exception_signal = " "
         if 'signal' in json_exception:
             exception_signal += "({})".format(json_exception['signal'])
 
         if 'codes' in json_exception:
             exception_extra = " ({})".format(json_exception['codes'])
def parse(self):
         return self.crashlog
 
 
     def parse_normal(self, line):
         if line.startswith('Process:'):
             (self.crashlog.process_name, pid_with_brackets) = line[
                 8:].strip().split(' [')
             self.crashlog.process_id = pid_with_brackets.strip('[]')
-        elif line.startswith('Path:'):
-            self.crashlog.process_path = line[5:].strip()
         elif line.startswith('Identifier:'):
             self.crashlog.process_identifier = line[11:].strip()
         elif line.startswith('Version:'):
             version_string = line[8:].strip()
             matched_pair = re.search("(.+)\((.+)\)", version_string)
             if matched_pair:
                 self.crashlog.process_version = matched_pair.group(1)
                 self.crashlog.process_compatability_version = matched_pair.group(

lldb/test/Shell/ScriptInterpreter/Python/Crashlog/parser_json.test

 #                                                                 -*- python -*-
 # RUN: cd %S/../../../../../examples/python && cat %s | %lldb 2>&1 > %t.out
 # RUN: cat %t.out | FileCheck %S/Inputs/Assertion.check
 script
 import crashlog
 import json
 
 parser = crashlog.JSONCrashLogParser("", "", False)
 
-process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd", "procPath" : "\/usr\/sbin\/mediaserverd"}')
+process_info_json = json.loads('{"pid" : 287, "procName" : "mediaserverd"}')
 parser.parse_process_info(process_info_json)
 
 assert parser.crashlog.process_id == 287
 assert parser.crashlog.process_identifier == "mediaserverd"
-assert parser.crashlog.process_path == "/usr/sbin/mediaserverd"
 
 crash_reason_json = json.loads('{"type" : "EXC_BAD_ACCESS", "signal" : "SIGSEGV", "subtype" : "KERN_INVALID_ADDRESS"}')
 assert parser.parse_crash_reason(crash_reason_json) == "EXC_BAD_ACCESS (SIGSEGV) (KERN_INVALID_ADDRESS)"
 
 crash_reason_json = json.loads('{"type" : "EXC_BAD_ACCESS", "signal" : "SIGSEGV"}')
 assert parser.parse_crash_reason(crash_reason_json) == "EXC_BAD_ACCESS (SIGSEGV)"
 
 crash_reason_json = json.loads('{"type" : "EXC_BAD_ACCESS", "signal" : "SIGSEGV", "codes" : "0x0000000000000000, 0x0000000000000000"}')