[lldb/crashlog] Update frame regex matcher

[mib]

Summary

This patch updates the regular expression matching stackframes in
crashlog to allow addresses that are 7 characters long and more (vs. 8
characters previously).

It changes the 0x[0-9a-fA-F]{7}[0-9a-fA-F]+ by 0x[0-9a-fA-F]{7,}.

rdar://97684839

Signed-off-by: Med Ismail Bennani <[e-mail]>

[kastiglione]

lldb/examples/python/crashlog.py

604

Can it be simplified to using {7,}, for "7 or more"?

Ex: r'(0x[0-9a-fA-F]{7,}

[JDevlieghere]

lldb/examples/python/crashlog.py

604

I like this idea (and learned something new)

[mib]

lldb/examples/python/crashlog.py

604

+1, thanks @kastiglione !

[mib]

Implement @kastiglione's suggestion

[JDevlieghere]

Can we test this by modifying an address in the existing test case?

[mib]

In D131032#3698108, @JDevlieghere wrote:

Can we test this by modifying an address in the existing test case?

Sure but we won't be able to symbolicate that frame anymore ... do we really want to do that ?

[JDevlieghere]

In D131032#3698163, @mib wrote:

In D131032#3698108, @JDevlieghere wrote:

Can we test this by modifying an address in the existing test case?

Sure but we won't be able to symbolicate that frame anymore ... do we really want to do that ?

I think that's a fair trade-off to get regression coverage.

[mib]

Add test

[JDevlieghere]

LGTM

lldb/examples/python/crashlog.py

 
 class TextCrashLogParser:
     parent_process_regex = re.compile('^Parent Process:\s*(.*)\[(\d+)\]')
     thread_state_regex = re.compile('^Thread ([0-9]+) crashed with')
     thread_instrs_regex = re.compile('^Thread ([0-9]+) instruction stream')
     thread_regex = re.compile('^Thread ([0-9]+)([^:]*):(.*)')
     app_backtrace_regex = re.compile('^Application Specific Backtrace ([0-9]+)([^:]*):(.*)')
     version = r'(\(.+\)|(arm|x86_)[0-9a-z]+)\s+'
-    frame_regex = re.compile(r'^([0-9]+)' r'\s'                # id
-                             r'+(.+?)'    r'\s+'               # img_name
-                             r'(' +version+ r')?'              # img_version
-                             r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]+)' # addr
-                             r' +(.*)'                         # offs
+    frame_regex = re.compile(r'^([0-9]+)' r'\s+'                # id
+                             r'(.+?)' r'\s+'                    # img_name
+                             r'(' +version+ r')?'               # img_version
+                             r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)'  # addr
+                             r' +(.*)'                          # offs
                             )
     null_frame_regex = re.compile(r'^([0-9]+)\s+\?\?\?\s+(0{7}0+) +(.*)')
     image_regex_uuid = re.compile(r'(0x[0-9a-fA-F]+)'            # img_lo
                                   r'\s+' '-' r'\s+'              #   -
                                   r'(0x[0-9a-fA-F]+)'     r'\s+' # img_hi
                                   r'[+]?(.+?)'            r'\s+' # img_name
                                   r'(' +version+ ')?'            # img_version
                                   r'(<([-0-9a-fA-F]+)>\s+)?'     # img_uuid