Details
Details
- Reviewers
Mordante var-const - Group Reviewers
Restricted Project - Commits
- rG495519e5f823: [libc++][NFC] Don't rely on `<algorithm>` transitively including `<memory>` in…
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
@fsb4000 Thank you for the patch! Would you mind to update the description to something like the following?
[libc++][NFC] Don't rely on `<algorithm>` transitively including `<memory>` in tests
(The current description identifies the problem; I think it would be clearer to describe the fix instead)
libcxx/test/std/algorithms/ranges_result_alias_declarations.compile.pass.cpp | ||
---|---|---|
17 | In libc++, <algorithm> transitively includes <memory>, which must be why we never noticed. |
Comment Actions
Would you mind to update the description to something like the following?
Sure.
Done.
In libc++, <algorithm> transitively includes <memory>, which must be why we never noticed.