Page MenuHomePhabricator

cpplearner (S. B. Tam)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2016, 10:24 PM (139 w, 2 d)

Recent Activity

Yesterday

cpplearner committed rG8fd6aa5ed2d6: [SemaDeclCXX] Allow inheriting constructor declaration to specify a cv… (authored by cpplearner).
[SemaDeclCXX] Allow inheriting constructor declaration to specify a cv…
Sat, Aug 17, 1:58 PM
cpplearner committed rL369196: [SemaDeclCXX] Allow inheriting constructor declaration to specify a cv….
[SemaDeclCXX] Allow inheriting constructor declaration to specify a cv…
Sat, Aug 17, 1:57 PM
cpplearner closed D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type.
Sat, Aug 17, 1:57 PM · Restricted Project, Restricted Project
cpplearner added a project to D41412: [libcxx] implement <experimental/simd> concat() and split(): Restricted Project.
Sat, Aug 17, 1:07 PM · Restricted Project

Mon, Aug 12

Herald added a project to D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type: Restricted Project.

ping

Mon, Aug 12, 3:29 AM · Restricted Project, Restricted Project
cpplearner added a comment to D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.

ping

Mon, Aug 12, 3:27 AM · Restricted Project

Tue, Jul 30

cpplearner added a comment to D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.

The noexcept specifier is part of the type these days, is that also handled properly?

Tue, Jul 30, 1:46 PM · Restricted Project

Mon, Jul 29

cpplearner added a comment to D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.

ping

Mon, Jul 29, 5:02 PM · Restricted Project

Tue, Jul 23

cpplearner added a comment to D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.

Is this the only place where a compound type can contain a PackExpansionType?

Tue, Jul 23, 3:15 PM · Restricted Project
cpplearner updated the diff for D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.
Tue, Jul 23, 3:09 PM · Restricted Project

Sun, Jul 21

cpplearner created D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion.
Sun, Jul 21, 6:32 AM · Restricted Project

Apr 24 2019

cpplearner added a comment to D61027: Fix crash on switch conditions of non-integer types in templates.

(I am ensadc at bugzilla)

Apr 24 2019, 11:43 AM · Restricted Project

Apr 14 2019

cpplearner added a comment to D60371: Add lerp function to cmath (P0811R3).

As mentioned in https://math.stackexchange.com/questions/907327/accurate-floating-point-linear-interpolation, given

Apr 14 2019, 10:21 PM

Mar 20 2019

cpplearner added inline comments to D59467: [clang] Adding the Likelihood Attribute from C++2a.
Mar 20 2019, 4:38 PM · Restricted Project

Jan 22 2019

cpplearner added inline comments to D57032: [SemaCXX] Param diagnostic matches overload logic.
Jan 22 2019, 5:59 AM · Restricted Project

Dec 17 2018

cpplearner committed rL349444: [ExprConstant] Handle compound assignment when LHS has integral type and RHS….
[ExprConstant] Handle compound assignment when LHS has integral type and RHS…
Dec 17 2018, 11:41 PM
cpplearner committed rC349444: [ExprConstant] Handle compound assignment when LHS has integral type and RHS….
[ExprConstant] Handle compound assignment when LHS has integral type and RHS…
Dec 17 2018, 11:41 PM
cpplearner closed D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 17 2018, 11:41 PM
cpplearner committed rC349384: [NFC] Test commit: tweak whitespace in comment.
[NFC] Test commit: tweak whitespace in comment
Dec 17 2018, 11:56 AM
cpplearner committed rL349384: [NFC] Test commit: tweak whitespace in comment.
[NFC] Test commit: tweak whitespace in comment
Dec 17 2018, 11:56 AM

Dec 14 2018

cpplearner added inline comments to D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 14 2018, 9:45 AM
cpplearner updated the diff for D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 14 2018, 9:35 AM

Dec 13 2018

cpplearner added inline comments to D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 13 2018, 1:04 AM

Dec 12 2018

cpplearner added inline comments to D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 12 2018, 6:49 AM

Dec 11 2018

cpplearner updated the diff for D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.

Added parentheses. Restored the original tests and add more tests to the end of this function.

Dec 11 2018, 8:23 AM
cpplearner added inline comments to D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 11 2018, 8:23 AM
cpplearner updated the diff for D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 11 2018, 7:44 AM
cpplearner added reviewers for D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type: rjmccall, efriedma.
Dec 11 2018, 7:28 AM

Dec 6 2018

cpplearner created D55413: [ExprConstant] Handle compound assignment when LHS has integral type and RHS has floating point type.
Dec 6 2018, 11:33 PM

Jul 16 2018

cpplearner added inline comments to rL337152: [Sema] Reword warning for constant captures that are not required.
Jul 16 2018, 3:12 AM

May 30 2018

cpplearner added a comment to D44480: [Sema] Don't skip function bodies with 'auto' without trailing return type.

Does getAs<AutoType>() work correctly with function returning auto&?

May 30 2018, 8:09 PM
cpplearner added inline comments to D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type.
May 30 2018, 5:34 AM · Restricted Project, Restricted Project

May 27 2018

cpplearner created D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type.
May 27 2018, 3:36 AM · Restricted Project, Restricted Project

Apr 11 2018

cpplearner added a comment to D45403: Make [[maybe_unused]] work with static data members.

I do not have commit access. Could someone commit the change for me?

Apr 11 2018, 11:34 PM

Apr 10 2018

cpplearner updated the diff for D45403: Make [[maybe_unused]] work with static data members.

Removed ExpectedForMaybeUnused from AttributeList.h, and removed the entry for ExpectedForMaybeUnused from the warn_attribute_wrong_decl_type table definition.

Apr 10 2018, 11:21 AM
cpplearner added a comment to D45403: Make [[maybe_unused]] work with static data members.

I don't think we're currently diagnosing static data members of classes as being unused in the first place; are there plans to implement that functionality so that someone might want to write the attribute there?

Apr 10 2018, 11:06 AM

Apr 7 2018

cpplearner added inline comments to D45403: Make [[maybe_unused]] work with static data members.
Apr 7 2018, 4:23 AM
cpplearner created D45403: Make [[maybe_unused]] work with static data members.
Apr 7 2018, 3:45 AM

Jan 14 2017

cpplearner added a comment to D27850: [libcxx] add missing constexpr to optional::value_or.

Yes, I do. Thank you.

Jan 14 2017, 5:04 AM

Dec 29 2016

cpplearner updated the diff for D27850: [libcxx] add missing constexpr to optional::value_or.

backed out the changes to <experimental/optional>

Dec 29 2016, 12:39 AM

Dec 27 2016

cpplearner updated the diff for D27850: [libcxx] add missing constexpr to optional::value_or.
Dec 27 2016, 11:10 AM
cpplearner updated the diff for D27850: [libcxx] add missing constexpr to optional::value_or.

test updated

Dec 27 2016, 10:50 AM

Dec 16 2016

cpplearner retitled D27850: [libcxx] add missing constexpr to optional::value_or from to [libcxx] add missing constexpr to optional::value_or.
Dec 16 2016, 7:30 AM