[LLDB][Reliability] Remove dead code.

[fixathon]

Summary

Remove redundant code that can never execute due to preceeding logic checks in the code.

[DavidSpickett]

LGTM

lldb/source/API/SBFrame.cpp

SBValueList SBFrame::GetVariables(bool arguments, bool locals, bool statics,
   ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
 
   StackFrame *frame = exe_ctx.GetFramePtr();
   Target *target = exe_ctx.GetTargetPtr();
   if (frame && target) {
     lldb::DynamicValueType use_dynamic =
         frame->CalculateTarget()->GetPreferDynamicValue();
     const bool include_runtime_support_values =
-        target ? target->GetDisplayRuntimeSupportValues() : false;
+        target->GetDisplayRuntimeSupportValues();
 
     SBVariablesOptions options;
     options.SetIncludeArguments(arguments);
     options.SetIncludeLocals(locals);
     options.SetIncludeStatics(statics);
     options.SetInScopeOnly(in_scope_only);
     options.SetIncludeRuntimeSupportValues(include_runtime_support_values);
     options.SetUseDynamic(use_dynamic);

lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp

if (is_return_value) {
       if (reg_num == LLDB_INVALID_REGNUM)
         return false;
       reg_info = reg_ctx->GetRegisterInfoAtIndex(reg_num);
       if (reg_info == nullptr)
         return false;
       ++NGRN;
     }
 
-    if (reg_info == nullptr)
-      return false;
-
     const lldb::addr_t value_addr =
         reg_ctx->ReadRegisterAsUnsigned(reg_info, LLDB_INVALID_ADDRESS);
 
     if (value_addr == LLDB_INVALID_ADDRESS)
       return false;
 
     if (exe_ctx.GetProcessRef().ReadMemory(
             value_addr, heap_data_up->GetBytes(), heap_data_up->GetByteSize(),

lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp

if (is_return_value) {
 
       reg_info = reg_ctx->GetRegisterInfo(eRegisterKindGeneric,
                                           LLDB_REGNUM_GENERIC_ARG1 + NGRN);
       if (reg_info == nullptr)
         return false;
       ++NGRN;
     }
 
-    if (reg_info == nullptr)
-      return false;
-
     const lldb::addr_t value_addr =
         reg_ctx->ReadRegisterAsUnsigned(reg_info, LLDB_INVALID_ADDRESS);
 
     if (value_addr == LLDB_INVALID_ADDRESS)
       return false;
 
     if (exe_ctx.GetProcessRef().ReadMemory(
             value_addr, heap_data_up->GetBytes(), heap_data_up->GetByteSize(),

lldb/source/Plugins/Language/ObjC/CoreMedia.cpp

if (flags.AnySet(FlagPositiveInf)) {
     return true;
   }
 
   if (flags.AnySet(FlagNegativeInf)) {
     stream.Printf("-oo");
     return true;
   }
 
-  if (timescale == 0)
-    return false;
-
   switch (timescale) {
   case 0:
     return false;
   case 1:
     stream.Printf("%" PRId64 " seconds", value);
     return true;
   case 2:
     stream.Printf("%" PRId64 " half seconds", value);

lldb/source/Target/Platform.cpp

 
 lldb::ProcessSP Platform::DoConnectProcess(llvm::StringRef connect_url,
                                            llvm::StringRef plugin_name,
                                            Debugger &debugger, Stream *stream,
                                            Target *target, Status &error) {
   error.Clear();
 
   if (!target) {
-    ArchSpec arch;
-    if (target && target->GetArchitecture().IsValid())
-      arch = target->GetArchitecture();
-    else
-      arch = Target::GetDefaultArchitecture();
+    ArchSpec arch = Target::GetDefaultArchitecture();
 
-    const char *triple = "";
-    if (arch.IsValid())
-      triple = arch.GetTriple().getTriple().c_str();
+    const char *triple =
+        arch.IsValid() ? arch.GetTriple().getTriple().c_str() : "";
 
     TargetSP new_target_sp;
     error = debugger.GetTargetList().CreateTarget(
         debugger, "", triple, eLoadDependentsNo, nullptr, new_target_sp);
-    target = new_target_sp.get();
-  }
 
-  if (!target || error.Fail())
+    target = new_target_sp.get();
+    if (!target || error.Fail()) {
       return nullptr;
+    }
+  }
 
   lldb::ProcessSP process_sp =
       target->CreateProcess(debugger.GetListener(), plugin_name, nullptr, true);
 
   if (!process_sp)
     return nullptr;
 
   // If this private method is called with a stream we are synchronous.