[tsan][test] Remaining tests requiring weak symbols for dyld64

[rsundahl]

Summary

This should be the last of the tests requiring weak symbols for Apple dyld64 > macOS 12.0. I would like to see dyld64 consider all symbols in the main program for weak-def-coalescing regardless of whether-or-not the program contains a weak symbol.

[MaskRay]

Wish that dyld can fix this functionality regression:)

compiler-rt/test/tsan/Darwin/debug_external.cpp

int main() {
   pthread_create(&t, 0, Thread, obj);
   *obj = 41;
   barrier_wait(&barrier);
   pthread_join(t, 0);
   fprintf(stderr, "Done.\n");
   return 0;
 }
 
-__attribute__((disable_sanitizer_instrumentation)) void
+// Required for dyld macOS 12.0+
+#if (__APPLE__)
+__attribute__((weak))
+#endif
+__attribute__((disable_sanitizer_instrumentation))
+extern "C" void
 __tsan_on_report(void *report) {
   const char *type;
   void *addr;
   void *start;
   unsigned long size;
   int tid, fd, suppressable;
   void *trace[16] = {0};
   __tsan_get_report_loc(report, 0, &type, &addr, &start, &size, &tid, &fd,

compiler-rt/test/tsan/Darwin/main_tid.mm

 // RUN: %clang_tsan %s -o %t -framework Foundation
 // RUN: %deflake %run %t 2>&1 | FileCheck %s
 
 #import <pthread.h>
 #import <stdio.h>
 #import <stdlib.h>
 
 extern "C" {
 void __tsan_on_report(void *report);
 int __tsan_get_report_thread(void *report, unsigned long idx, int *tid,
                              uint64_t *os_id, int *running,
                              const char **name, int *parent_tid, void **trace,
                              unsigned long trace_size);
 }
 
+// Required for dyld macOS 12.0+
+#if (__APPLE__)
+__attribute__((weak))
+#endif
 __attribute__((disable_sanitizer_instrumentation))
-void __tsan_on_report(void *report) {
+extern "C" void
+__tsan_on_report(void *report) {
   fprintf(stderr, "__tsan_on_report(%p)\n", report);
 
   int tid;
   uint64_t os_id;
   int running;
   const char *name;
   int parent_tid;
   void *trace[16] = {0};

compiler-rt/test/tsan/debugging.cpp

int main() {
   pthread_t t;
   pthread_create(&t, 0, Thread, 0);
   my_global = 41;
   barrier_wait(&barrier);
   pthread_join(t, 0);
   fprintf(stderr, "Done.\n");
 }
 
-__attribute__((disable_sanitizer_instrumentation)) void
+// Required for dyld macOS 12.0+
+#if (__APPLE__)
+__attribute__((weak))
+#endif
+__attribute__((disable_sanitizer_instrumentation))
+extern "C" void
 __tsan_on_report(void *report) {
   fprintf(stderr, "__tsan_on_report(%p)\n", report);
   fprintf(stderr, "__tsan_get_current_report() = %p\n",
           __tsan_get_current_report());
   // CHECK: __tsan_on_report([[REPORT:0x[0-9a-f]+]])
   // CHECK: __tsan_get_current_report() = [[REPORT]]
 
   const char *description;

compiler-rt/test/tsan/libdispatch/dispatch_once_deadlock.c

 void f() {
   static dispatch_once_t onceToken;
   dispatch_once(&onceToken, ^{
     g++;
   });
   h++;
 }
 
+// Required for dyld macOS 12.0+
+#if (__APPLE__)
+__attribute__((weak))
+#endif
 __attribute__((disable_sanitizer_instrumentation))
-void __tsan_on_report() {
+extern void
+__tsan_on_report() {
   fprintf(stderr, "Report.\n");
 
   // Without these annotations this test deadlocks for COMPILER_RT_DEBUG=ON
   // builds.  Conceptually, the TSan runtime does not support reentrancy from
   // runtime callbacks, but the main goal here is just to check that
   // dispatch_once() is always intercepted.
   AnnotateIgnoreSyncBegin(__FILE__, __LINE__);
   f();