This is an archive of the discontinued LLVM Phabricator instance.

[clang-repl] Disable execution unittests on unsupported platforms.
ClosedPublic

Authored by sunho on Jul 29 2022, 10:26 AM.

Download Raw Diff

Details

Reviewers: None
Commits: rG4191d661c746: [clang-repl] Disable execution unittests on unsupported platforms.

Summary

After the intoduction of global destructor support, there is a possiblity to run invalid instructions in the destructor of Interpreter class. Completely disable tests in platforms with failing test cases.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sunho created this revision.Jul 29 2022, 10:26 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 10:26 AM

sunho requested review of this revision.Jul 29 2022, 10:26 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 29 2022, 10:28 AM

This revision was landed with ongoing or failed builds.

Closed by commit rG4191d661c746: [clang-repl] Disable execution unittests on unsupported platforms. (authored by sunho). · Explain Why

This revision was automatically updated to reflect the committed changes.

sunho added a commit: rG4191d661c746: [clang-repl] Disable execution unittests on unsupported platforms..

Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 10:28 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

alanphipps added a subscriber: alanphipps.Jul 29 2022, 11:07 AM

Harbormaster completed remote builds in B178315: Diff 448673.Jul 29 2022, 11:15 AM

If you're going to post a patch for review, you really should wait for someone to review it before you land it.

In D130786#3688019, @probinson wrote:

If you're going to post a patch for review, you really should wait for someone to review it before you land it.

I rushed as bots were breaking on the upstream. Sorry about that.

I'm still seeing a failure on my downstream Arm compiler on Linux in the unit tests -- I thought I saw the same failure on the buildbots:

FAIL: llvm_regressions :: Clang-Unit/Interpreter/ClangReplInterpreterTests/1/8
3		--------------------------------------------------------------------------------
4		Script(shard):
5		--
6		GTEST_OUTPUT=json:/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests-Clang-Unit-39149-1-8.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=8 GTEST_SHARD_INDEX=1 /scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests
7		--
8		 
9		Note: This is test shard 2 of 8.
10		[==========] Running 1 test from 1 test suite.
11		[----------] Global test environment set-up.
12		[----------] 1 test from IncrementalProcessing
13		[ RUN      ] IncrementalProcessing.FindMangledNameSymbol
14		 #0 0x0000000000676fc3 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x676fc3)
15		 #1 0x0000000000674e1c llvm::sys::RunSignalHandlers() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x674e1c)
16		 #2 0x00000000006775c6 SignalHandler(int) (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x6775c6)
17		 #3 0x00007fa295c6f330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330)
18		 #4 0x0000000000b54a97 clang::IncrementalExecutor::cleanUp() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0xb54a97)
19		 #5 0x0000000000b521e4 clang::Interpreter::~Interpreter() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0xb521e4)
20		 #6 0x0000000000489a13 (anonymous namespace)::IncrementalProcessing_FindMangledNameSymbol_Test::TestBody() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x489a13)
21		 #7 0x000000000068889c testing::Test::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x68889c)
22		 #8 0x00000000006895c9 testing::TestInfo::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x6895c9)
23		 #9 0x0000000000689c77 testing::TestSuite::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x689c77)
24		#10 0x0000000000699647 testing::internal::UnitTestImpl::RunAllTests() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x699647)
25		#11 0x0000000000698ec3 testing::UnitTest::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x698ec3)
26		#12 0x0000000000680fec main (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x680fec)
27		#13 0x00007fa294d64f45 __libc_start_main /build/eglibc-xkFqqE/eglibc-2.19/csu/libc-start.c:321:0
28		#14 0x000000000047fff5 _start (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x47fff5)

In D130786#3688387, @alanphipps wrote:

I'm still seeing a failure on my downstream Arm compiler on Linux in the unit tests -- I thought I saw the same failure on the buildbots:

FAIL: llvm_regressions :: Clang-Unit/Interpreter/ClangReplInterpreterTests/1/8
3		--------------------------------------------------------------------------------
4		Script(shard):
5		--
6		GTEST_OUTPUT=json:/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests-Clang-Unit-39149-1-8.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=8 GTEST_SHARD_INDEX=1 /scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests
7		--
8		 
9		Note: This is test shard 2 of 8.
10		[==========] Running 1 test from 1 test suite.
11		[----------] Global test environment set-up.
12		[----------] 1 test from IncrementalProcessing
13		[ RUN      ] IncrementalProcessing.FindMangledNameSymbol
14		 #0 0x0000000000676fc3 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x676fc3)
15		 #1 0x0000000000674e1c llvm::sys::RunSignalHandlers() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x674e1c)
16		 #2 0x00000000006775c6 SignalHandler(int) (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x6775c6)
17		 #3 0x00007fa295c6f330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330)
18		 #4 0x0000000000b54a97 clang::IncrementalExecutor::cleanUp() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0xb54a97)
19		 #5 0x0000000000b521e4 clang::Interpreter::~Interpreter() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0xb521e4)
20		 #6 0x0000000000489a13 (anonymous namespace)::IncrementalProcessing_FindMangledNameSymbol_Test::TestBody() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x489a13)
21		 #7 0x000000000068889c testing::Test::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x68889c)
22		 #8 0x00000000006895c9 testing::TestInfo::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x6895c9)
23		 #9 0x0000000000689c77 testing::TestSuite::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x689c77)
24		#10 0x0000000000699647 testing::internal::UnitTestImpl::RunAllTests() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x699647)
25		#11 0x0000000000698ec3 testing::UnitTest::Run() (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x698ec3)
26		#12 0x0000000000680fec main (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x680fec)
27		#13 0x00007fa294d64f45 __libc_start_main /build/eglibc-xkFqqE/eglibc-2.19/csu/libc-start.c:321:0
28		#14 0x000000000047fff5 _start (/scratch/build_jenkins/workspace/Downstream_Changes/llvm_cgt/arm-llvm/RelWithAsserts/llvm/tools/clang/unittests/Interpreter/./ClangReplInterpreterTests+0x47fff5)

I'm aware it's not fixed yet. I have another fix on my local machine that I'm building right now -- I'll commit it once I confirmed it builds on my machine.

@alanphipps I just confirmed that the buildbot failures were fixed by the new fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this fixes the failure on your end too?

In D130786#3688503, @sunho wrote:

@alanphipps I just confirmed that the buildbot failures were fixed by the new fix https://reviews.llvm.org/rG65c9265f4158. Could you check out if this fixes the failure on your end too?

Yes it appears to be passing now. Thank you!

Revision Contents

Path

Size

clang/

unittests/

Interpreter/

ExceptionTests/

InterpreterExceptionTest.cpp

3 lines

InterpreterTest.cpp

10 lines

Diff 448674

clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp

Show All 40 Lines	createInterpreter(const Args &ExtraArgs = {},
ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end());		ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end());
auto CI = cantFail(clang::IncrementalCompilerBuilder::create(ClangArgs));		auto CI = cantFail(clang::IncrementalCompilerBuilder::create(ClangArgs));
if (Client)		if (Client)
CI->getDiagnostics().setClient(Client, /ShouldOwnClient=/false);		CI->getDiagnostics().setClient(Client, /ShouldOwnClient=/false);
return cantFail(clang::Interpreter::create(std::move(CI)));		return cantFail(clang::Interpreter::create(std::move(CI)));
}		}

TEST(InterpreterTest, CatchException) {		TEST(InterpreterTest, CatchException) {
		llvm::llvm_shutdown_obj Y; // Call llvm_shutdown() on exit.
llvm::InitializeNativeTarget();		llvm::InitializeNativeTarget();
llvm::InitializeNativeTargetAsmPrinter();		llvm::InitializeNativeTargetAsmPrinter();

{		{
auto J = llvm::orc::LLJITBuilder().create();		auto J = llvm::orc::LLJITBuilder().create();
if (!J) {		if (!J) {
// The platform does not support JITs.		// The platform does not support JITs.
// Using llvm::consumeError will require typeinfo for ErrorInfoBase, we		// Using llvm::consumeError will require typeinfo for ErrorInfoBase, we
▲ Show 20 Lines • Show All 68 Lines • ▼ Show 20 Lines	extern "C" int throw_exception() {

llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));		llvm::cantFail(Interp->ParseAndExecute(ExceptionCode));
testing::internal::CaptureStdout();		testing::internal::CaptureStdout();
auto ThrowException =		auto ThrowException =
(int (*)())llvm::cantFail(Interp->getSymbolAddress("throw_exception"));		(int (*)())llvm::cantFail(Interp->getSymbolAddress("throw_exception"));
EXPECT_ANY_THROW(ThrowException());		EXPECT_ANY_THROW(ThrowException());
std::string CapturedStdOut = testing::internal::GetCapturedStdout();		std::string CapturedStdOut = testing::internal::GetCapturedStdout();
EXPECT_EQ(CapturedStdOut, "Caught: 'To be caught in JIT'\n");		EXPECT_EQ(CapturedStdOut, "Caught: 'To be caught in JIT'\n");

llvm::llvm_shutdown();
}		}

} // end anonymous namespace		} // end anonymous namespace

clang/unittests/Interpreter/InterpreterTest.cpp

Show All 22 Lines
#include "llvm/Support/ManagedStatic.h"		#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/TargetSelect.h"		#include "llvm/Support/TargetSelect.h"

#include "gmock/gmock.h"		#include "gmock/gmock.h"
#include "gtest/gtest.h"		#include "gtest/gtest.h"

using namespace clang;		using namespace clang;

		#if defined(_AIX) \|\| defined(__hexagon__) \|\| \
		(defined(_WIN32) && \
		(defined(__aarch64__) \|\| defined(_M_ARM64) \|\| defined(__arm__)))
		#define CLANG_INTERPRETER_NO_SUPPORT_EXEC
		#endif

namespace {		namespace {
using Args = std::vector<const char *>;		using Args = std::vector<const char *>;
static std::unique_ptr<Interpreter>		static std::unique_ptr<Interpreter>
createInterpreter(const Args &ExtraArgs = {},		createInterpreter(const Args &ExtraArgs = {},
DiagnosticConsumer *Client = nullptr) {		DiagnosticConsumer *Client = nullptr) {
Args ClangArgs = {"-Xclang", "-emit-llvm-only"};		Args ClangArgs = {"-Xclang", "-emit-llvm-only"};
ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end());		ClangArgs.insert(ClangArgs.end(), ExtraArgs.begin(), ExtraArgs.end());
auto CI = cantFail(clang::IncrementalCompilerBuilder::create(ClangArgs));		auto CI = cantFail(clang::IncrementalCompilerBuilder::create(ClangArgs));
▲ Show 20 Lines • Show All 147 Lines • ▼ Show 20 Lines
struct LLVMInitRAII {		struct LLVMInitRAII {
LLVMInitRAII() {		LLVMInitRAII() {
llvm::InitializeNativeTarget();		llvm::InitializeNativeTarget();
llvm::InitializeNativeTargetAsmPrinter();		llvm::InitializeNativeTargetAsmPrinter();
}		}
~LLVMInitRAII() { llvm::llvm_shutdown(); }		~LLVMInitRAII() { llvm::llvm_shutdown(); }
} LLVMInit;		} LLVMInit;

#ifdef _AIX		#ifdef CLANG_INTERPRETER_NO_SUPPORT_EXEC
TEST(IncrementalProcessing, DISABLED_FindMangledNameSymbol) {		TEST(IncrementalProcessing, DISABLED_FindMangledNameSymbol) {
#else		#else
TEST(IncrementalProcessing, FindMangledNameSymbol) {		TEST(IncrementalProcessing, FindMangledNameSymbol) {
#endif		#endif

std::unique_ptr<Interpreter> Interp = createInterpreter();		std::unique_ptr<Interpreter> Interp = createInterpreter();

auto &PTU(cantFail(Interp->Parse("int f(const char*) {return 0;}")));		auto &PTU(cantFail(Interp->Parse("int f(const char*) {return 0;}")));
▲ Show 20 Lines • Show All 45 Lines • ▼ Show 20 Lines	static NamedDecl LookupSingleName(Interpreter &Interp, const char Name) {
ASTContext &C = SemaRef.getASTContext();		ASTContext &C = SemaRef.getASTContext();
DeclarationName DeclName = &C.Idents.get(Name);		DeclarationName DeclName = &C.Idents.get(Name);
LookupResult R(SemaRef, DeclName, SourceLocation(), Sema::LookupOrdinaryName);		LookupResult R(SemaRef, DeclName, SourceLocation(), Sema::LookupOrdinaryName);
SemaRef.LookupName(R, SemaRef.TUScope);		SemaRef.LookupName(R, SemaRef.TUScope);
assert(!R.empty());		assert(!R.empty());
return R.getFoundDecl();		return R.getFoundDecl();
}		}

#ifdef _AIX		#ifdef CLANG_INTERPRETER_NO_SUPPORT_EXEC
TEST(IncrementalProcessing, DISABLED_InstantiateTemplate) {		TEST(IncrementalProcessing, DISABLED_InstantiateTemplate) {
#else		#else
TEST(IncrementalProcessing, InstantiateTemplate) {		TEST(IncrementalProcessing, InstantiateTemplate) {
#endif		#endif
// FIXME: We cannot yet handle delayed template parsing. If we run with		// FIXME: We cannot yet handle delayed template parsing. If we run with
// -fdelayed-template-parsing we try adding the newly created decl to the		// -fdelayed-template-parsing we try adding the newly created decl to the
// active PTU which causes an assert.		// active PTU which causes an assert.
std::vector<const char *> Args = {"-fno-delayed-template-parsing"};		std::vector<const char *> Args = {"-fno-delayed-template-parsing"};
Show All 36 Lines