This is an archive of the discontinued LLVM Phabricator instance.

Differential D130768

[OpenCL][SPIR-V] Add test for extern functions with a pointer
ClosedPublic

Authored by Anastasia on Jul 29 2022, 5:58 AM.

Details

Reviewers
svenvh
iliya-diyachkov
Commits
rG6b1a04529c8f: [OpenCL][SPIR-V] Test extern functions with a pointer arg.
Summary

I would like to add this test case that enhances coverage of opaque pointers particularly for the problematic case with extern functions for which there is no solution found yet.

Diff Detail

Event Timeline

Anastasia created this revision.Jul 29 2022, 5:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 5:58 AM
Herald added subscribers: ebevhan, yaxunl. · View Herald Transcript
Anastasia requested review of this revision.Jul 29 2022, 5:58 AM
Harbormaster completed remote builds in B178266: Diff 448602.Jul 29 2022, 6:35 AM
iliya-diyachkov accepted this revision.Aug 5 2022, 12:49 PM

Looks good to me.

This revision is now accepted and ready to land.Aug 5 2022, 12:49 PM
svenvh accepted this revision.Aug 19 2022, 7:34 AM

LGTM.

Closed by commit rG6b1a04529c8f: [OpenCL][SPIR-V] Test extern functions with a pointer arg. (authored by Anastasia). · Explain WhySep 1 2022, 2:23 AM
This revision was automatically updated to reflect the committed changes.
Anastasia added a commit: rG6b1a04529c8f: [OpenCL][SPIR-V] Test extern functions with a pointer arg..
Herald added a project: Restricted Project. · View Herald TranscriptSep 1 2022, 2:23 AM
Herald added a subscriber: ldrumm. · View Herald Transcript

Revision Contents

PathSize
clang/
test/
CodeGenOpenCL/
10 lines

Diff 457208

clang/test/CodeGenOpenCL/opaque-ptr-spirv.cl

  • This file was added.
// RUN: %clang_cc1 -no-opaque-pointers -emit-llvm -o - -triple spirv64 %s | FileCheck %s
// Check that we have a way to recover pointer
// types for extern function prototypes (see PR56660).
extern void foo(global int * ptr);
kernel void k(global int * ptr) {
foo(ptr);
}
//CHECK: define spir_kernel void @k(i32 {{.*}}*
//CHECK: declare spir_func void @foo(i32 {{.*}}*