Migrating all private STL code to the standard STL case but keeping it under the CPP namespace to avoid confusion. Starting with the type_traits header.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
libc/src/__support/CPP/type_traits.h | ||
---|---|---|
48 | Here and in is_floating_point, you have not updated TypeNoCV? May be do it for consistency, and because you are touching, make them private? |
Comment Actions
This patch broke the build and needed these three subsequent commits
- https://github.com/llvm/llvm-project/commit/039fb3e5a12fccacd6ee5272e461e7e186397636
- https://github.com/llvm/llvm-project/commit/e5e0e7963cd6d4500bb7c4c4aa2c90bddc8468f8
- https://github.com/llvm/llvm-project/commit/0c3037dfc555887fc7b63069d5bff57e04759f06
Next time I will revert and reland...
Here and in is_floating_point, you have not updated TypeNoCV? May be do it for consistency, and because you are touching, make them private?