This is an archive of the discontinued LLVM Phabricator instance.

[libc][NFC] Use STL case for type_traits
ClosedPublic

Authored by gchatelet on Jul 28 2022, 12:41 PM.

Details

Summary

Migrating all private STL code to the standard STL case but keeping it under the CPP namespace to avoid confusion. Starting with the type_traits header.

Diff Detail

Event Timeline

gchatelet created this revision.Jul 28 2022, 12:41 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 28 2022, 12:41 PM
gchatelet requested review of this revision.Jul 28 2022, 12:41 PM
gchatelet updated this revision to Diff 448426.Jul 28 2022, 1:11 PM
  • Fix one missing Value->value and rename header to type_traits.h
sivachandra accepted this revision.Jul 29 2022, 12:55 AM
sivachandra added a subscriber: sivachandra.
sivachandra added inline comments.
libc/src/__support/CPP/type_traits.h
49

Here and in is_floating_point, you have not updated TypeNoCV? May be do it for consistency, and because you are touching, make them private?

This revision is now accepted and ready to land.Jul 29 2022, 12:55 AM
gchatelet updated this revision to Diff 448555.Jul 29 2022, 2:30 AM
gchatelet marked an inline comment as done.
  • Address comments
gchatelet updated this revision to Diff 448558.Jul 29 2022, 2:45 AM
  • Also fix clang-format warnings
This revision was landed with ongoing or failed builds.Jul 29 2022, 2:57 AM
This revision was automatically updated to reflect the committed changes.
libc/src/__support/CPP/ArrayRef.h