This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Extend the CaptureTracking to handle constantExprs that read global variables
Needs RevisionPublic

Authored by drcut on Jul 27 2022, 4:26 PM.

Details

Summary

This patch optimizes dead store which cannot be optimized due to the previous capture tracking which does not concern Constant Expression

Diff Detail

Event Timeline

drcut created this revision.Jul 27 2022, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2022, 4:26 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
drcut requested review of this revision.Jul 27 2022, 4:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2022, 4:26 PM
drcut edited the summary of this revision. (Show Details)Jul 27 2022, 4:28 PM
drcut added reviewers: asbirlea, aeubanks.
nikic requested changes to this revision.Jul 28 2022, 12:29 AM
nikic added a subscriber: nikic.

This code is known to be incorrect, so rejecting its extension. See https://github.com/llvm/llvm-project/issues/54002, as well as D120371 for the proper way to handle this.

This revision now requires changes to proceed.Jul 28 2022, 12:29 AM