[mlir] Small stylistic changes to Complex_NumberAttr

[Lewuathe]

The change looks good to me. Thanks for the cleanup!

mlir/include/mlir/Dialect/Complex/IR/ComplexAttributes.td

37–39

It might be better to add a description field here. (Sorry, I forgot to add them)

APFloatParameter<"real part">:$real, APFloatParameter<"imaginary part">:$imag

[akuegel]

Thanks :)

mlir/include/mlir/Dialect/Complex/IR/ComplexAttributes.td

let description = [{
 
     Example:
 
     ```mlir
     #complex.number<:f64 1.0, 2.0>
     ```
   }];
 
-  let parameters = (ins APFloatParameter<"">:$real, APFloatParameter<"">:$imag, AttributeSelfTypeParameter<"">:$type);
-
+  let parameters = (ins APFloatParameter<"">:$real,
+                        APFloatParameter<"">:$imag,
+                        AttributeSelfTypeParameter<"">:$type);
   let genVerifyDecl = 1;
   let hasCustomAssemblyFormat = 1;
 }
 
 #endif // COMPLEX_ATTRIBUTE

mlir/lib/Dialect/Complex/IR/ComplexDialect.cpp

LogicalResult complex::NumberAttr::verify(
   if (&imag.getSemantics() != &typeFloatSemantics)
     return emitError()
            << "type doesn't match the type implied by its `imag` value";
 
   return success();
 }
 
 void complex::NumberAttr::print(AsmPrinter &printer) const {
-  printer << "<:";
-  printer.printType(getType());
-  printer << " ";
-  printer.printFloat(getReal());
-  printer << ", ";
-  printer.printFloat(getImag());
-  printer << ">";
+  printer << "<:" << getType() << " " << getReal() << ", " << getImag() << ">";
 }
 
 Attribute complex::NumberAttr::parse(AsmParser &parser, Type odsType) {
-  if (failed(parser.parseLess()))
-    return {};
-
-  if (failed(parser.parseColon()))
-    return {};
-
   Type type;
-  if (failed(parser.parseType(type)))
-    return {};
-
-  double real;
-  if (failed(parser.parseFloat(real)))
-    return {};
-
-  if (failed(parser.parseComma()))
-    return {};
-
-  double imag;
-  if (failed(parser.parseFloat(imag)))
-    return {};
-
-  if (failed(parser.parseGreater()))
+  double real, imag;
+  if (parser.parseLess() || parser.parseColon() || parser.parseType(type) ||
+      parser.parseFloat(real) || parser.parseComma() ||
+      parser.parseFloat(imag) || parser.parseGreater())
     return {};
 
   bool unused = false;
-  auto realFloat = APFloat(real);
+  APFloat realFloat(real);
   realFloat.convert(type.cast<FloatType>().getFloatSemantics(),
                     APFloat::rmNearestTiesToEven, &unused);
-  auto imagFloat = APFloat(imag);
+  APFloat imagFloat(imag);
   imagFloat.convert(type.cast<FloatType>().getFloatSemantics(),
                     APFloat::rmNearestTiesToEven, &unused);
-
   return NumberAttr::get(parser.getContext(), realFloat, imagFloat, type);
 }