This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Reintroduce host architecture checks for device RTL
ClosedPublic

Authored by jhuber6 on Jul 25 2022, 12:26 PM.

Details

Summary

A previous patch removed the need to set the auxiliary architecture as
it was no longer needed for the clang invocation after moving to using
the clang frontend. However, this had a second use of preventing
unsupported host architectures from building the device runtime. This
caused failures when trying to build on 32-bit hosts for example.

Fixes #56699

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 25 2022, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 12:26 PM
Herald added a subscriber: mgorny. · View Herald Transcript
jhuber6 requested review of this revision.Jul 25 2022, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 12:26 PM
tianshilei1992 added inline comments.Jul 25 2022, 1:02 PM
openmp/libomptarget/DeviceRTL/CMakeLists.txt
22

I remember there is a bug report about the name of host arch is not consistent among different OSs. If we just want to disable build for 32-bit system, we might want something else.

jhuber6 updated this revision to Diff 447456.Jul 25 2022, 1:47 PM

Updating to use sizeof pointer instead to elimate support for 32-bit hosts.

This revision is now accepted and ready to land.Jul 25 2022, 1:49 PM
This revision was landed with ongoing or failed builds.Jul 25 2022, 2:01 PM
This revision was automatically updated to reflect the committed changes.