This is an archive of the discontinued LLVM Phabricator instance.

Differential D130493

Disable stack-sizes section by default for PS4.
ClosedPublic

Authored by MaggieYi on Jul 25 2022, 8:47 AM.

Details

Reviewers
probinson
wristow
MaskRay
Commits
rGbfe191dfa79b: Disable stack-sizes section by default for PS4.
Summary

Change Clang's default so that -fstack-size-section is no longer enabled by default for PS4.

Diff Detail

Event Timeline

MaggieYi created this revision.Jul 25 2022, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 8:47 AM
MaggieYi requested review of this revision.Jul 25 2022, 8:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2022, 8:47 AM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B177395: Diff 447356.Jul 25 2022, 9:12 AM
probinson accepted this revision.Jul 25 2022, 10:50 AM

LGTM

This revision is now accepted and ready to land.Jul 25 2022, 10:50 AM
wristow accepted this revision.Jul 25 2022, 10:54 AM
MaskRay added inline comments.Jul 25 2022, 12:11 PM
clang/lib/Driver/ToolChains/Clang.cpp
5888–5889

Switch to Args.addOptInFlag

MaggieYi updated this revision to Diff 447756.Jul 26 2022, 10:34 AM

Use Args.addOptInFlag instead of Args.hasFlag, thanks.

MaskRay accepted this revision.Jul 26 2022, 10:59 AM
Herald added a subscriber: StephenFan. · View Herald TranscriptJul 26 2022, 10:59 AM
Harbormaster completed remote builds in B177656: Diff 447756.Jul 26 2022, 11:22 AM
wristow accepted this revision.Jul 26 2022, 11:31 AM
This revision was landed with ongoing or failed builds.Jul 27 2022, 1:38 AM
Closed by commit rGbfe191dfa79b: Disable stack-sizes section by default for PS4. (authored by MaggieYi). · Explain Why
This revision was automatically updated to reflect the committed changes.
MaggieYi added a commit: rGbfe191dfa79b: Disable stack-sizes section by default for PS4..

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
5 lines
test/
Driver/
2 lines

Diff 447948

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 5,879 Lines • ▼ Show 20 Lines if (Arg *A = Args.getLastArg(options::OPT_fconstant_string_class_EQ)) {
CmdArgs.push_back("-fconstant-string-class"); CmdArgs.push_back("-fconstant-string-class");
CmdArgs.push_back(A->getValue()); CmdArgs.push_back(A->getValue());
} }
if (Arg *A = Args.getLastArg(options::OPT_ftabstop_EQ)) { if (Arg *A = Args.getLastArg(options::OPT_ftabstop_EQ)) {
CmdArgs.push_back("-ftabstop"); CmdArgs.push_back("-ftabstop");
CmdArgs.push_back(A->getValue()); CmdArgs.push_back(A->getValue());
} }
if (Args.hasFlag(options::OPT_fstack_size_section, Args.addOptInFlag(CmdArgs, options::OPT_fstack_size_section,
MaskRayUnsubmitted
Not Done
ReplyInline Actions

Switch to Args.addOptInFlag

MaskRay: Switch to `Args.addOptInFlag`
options::OPT_fno_stack_size_section, RawTriple.isPS4())) options::OPT_fno_stack_size_section);
CmdArgs.push_back("-fstack-size-section");
if (Args.hasArg(options::OPT_fstack_usage)) { if (Args.hasArg(options::OPT_fstack_usage)) {
CmdArgs.push_back("-stack-usage-file"); CmdArgs.push_back("-stack-usage-file");
if (Arg *OutputOpt = Args.getLastArg(options::OPT_o)) { if (Arg *OutputOpt = Args.getLastArg(options::OPT_o)) {
SmallString<128> OutputFilename(OutputOpt->getValue()); SmallString<128> OutputFilename(OutputOpt->getValue());
llvm::sys::path::replace_extension(OutputFilename, "su"); llvm::sys::path::replace_extension(OutputFilename, "su");
CmdArgs.push_back(Args.MakeArgString(OutputFilename)); CmdArgs.push_back(Args.MakeArgString(OutputFilename));
▲ Show 20 Lines • Show All 2,606 Lines • Show Last 20 Lines

clang/test/Driver/stack-size-section.c

// RUN: %clang -target x86_64-unknown %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT // RUN: %clang -target x86_64-unknown %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT
// RUN: %clang -target x86_64-sie-ps5 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT // RUN: %clang -target x86_64-sie-ps5 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT
// RUN: %clang -target x86_64-scei-ps4 -fno-stack-size-section %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT // RUN: %clang -target x86_64-scei-ps4 -fno-stack-size-section %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT
// CHECK-ABSENT-NOT: -fstack-size-section // CHECK-ABSENT-NOT: -fstack-size-section
// RUN: %clang -target x86_64-unknown -fstack-size-section -### 2>&1 | FileCheck %s --check-prefix=CHECK-PRESENT // RUN: %clang -target x86_64-unknown -fstack-size-section -### 2>&1 | FileCheck %s --check-prefix=CHECK-PRESENT
// RUN: %clang -target x86_64-scei-ps4 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-PRESENT // RUN: %clang -target x86_64-scei-ps4 %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-ABSENT
// CHECK-PRESENT: -fstack-size-section // CHECK-PRESENT: -fstack-size-section
// RUN: %clang -target x86_64-unknown -fstack-size-section -fno-stack-size-section %s -### 2>&1 \ // RUN: %clang -target x86_64-unknown -fstack-size-section -fno-stack-size-section %s -### 2>&1 \
// RUN: | FileCheck %s --check-prefix=CHECK-ABSENT // RUN: | FileCheck %s --check-prefix=CHECK-ABSENT
// RUN: %clang -target x86_64-unknown -fno-stack-size-section -fstack-size-section %s -### 2>&1 \ // RUN: %clang -target x86_64-unknown -fno-stack-size-section -fstack-size-section %s -### 2>&1 \
// RUN: | FileCheck %s --check-prefix=CHECK-PRESENT // RUN: | FileCheck %s --check-prefix=CHECK-PRESENT
int foo() { return 42; } int foo() { return 42; }