This is an archive of the discontinued LLVM Phabricator instance.

Windows packaging script. Script does not exit on configure/build/test failure.
ClosedPublic

Authored by CarlosAlbertoEnciso on Jul 20 2022, 1:56 AM.

Details

Summary

Due to a missing new line, the error code returned by the function is taking as another argument.

call :function if errorlevel 1 exit /b 1

The code should be

call :function
if errorlevel 1 exit /b 1

Changed to use a simple '||' logic
call :function || exit /b 1

Diff Detail

Event Timeline

CarlosAlbertoEnciso requested review of this revision.Jul 20 2022, 1:56 AM
CarlosAlbertoEnciso created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2022, 1:56 AM
hans accepted this revision.Jul 20 2022, 5:03 AM

lgtm

This revision is now accepted and ready to land.Jul 20 2022, 5:03 AM
This revision was landed with ongoing or failed builds.Jul 20 2022, 5:23 AM
This revision was automatically updated to reflect the committed changes.