This is an archive of the discontinued LLVM Phabricator instance.

[Libomptarget] Fix warnings on address space attributes
ClosedPublic

Authored by jhuber6 on Jul 15 2022, 12:36 PM.

Details

Summary

The device runtime uses the address space attribute to control the
placement of important constants on the GPU. The changes made in D126061
caused these to start emitting errors as they were not applied to the
type. This patch fixes the issues to make the warnings go away.

Diff Detail

Event Timeline

jhuber6 created this revision.Jul 15 2022, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 12:36 PM
jhuber6 requested review of this revision.Jul 15 2022, 12:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 15 2022, 12:36 PM
ye-luo accepted this revision.Jul 15 2022, 12:46 PM
ye-luo added a subscriber: ye-luo.

Great!

This revision is now accepted and ready to land.Jul 15 2022, 12:46 PM
This revision was automatically updated to reflect the committed changes.