This is an archive of the discontinued LLVM Phabricator instance.

[libc++][AIX][test] Remove XFAIL for libcpp_deallocate.sh.cpp
AbandonedPublic

Authored by ZarkoCA on Jul 13 2022, 3:56 PM.

Details

Reviewers
daltenty
hubert.reinterpretcast
Mordante
Group Reviewers
Restricted Project
Summary

Diff Detail

Event Timeline

ZarkoCA created this revision.Jul 13 2022, 3:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 3:56 PM
ZarkoCA requested review of this revision.Jul 13 2022, 3:56 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 13 2022, 3:56 PM
daltenty accepted this revision.Jul 14 2022, 4:10 PM

LGTM, but we'll need to update the build compiler with the fix as well to get the CI to pass

Mordante accepted this revision.Jul 15 2022, 10:01 AM
Mordante added a subscriber: Mordante.

LGTM from the libc++ side.

LGTM, but we'll need to update the build compiler with the fix as well to get the CI to pass

But please make sure this is done and the CI is green before landing this patch.

This revision is now accepted and ready to land.Jul 15 2022, 10:01 AM
ZarkoCA abandoned this revision.Jul 26 2022, 6:53 AM

Looks like I was beat to committing this by https://github.com/llvm/llvm-project/commit/9566c4a682065105a653c4c148325671755faace. Abandoning since the change is already in.