This is an archive of the discontinued LLVM Phabricator instance.

[test] Fix macOS triple check
ClosedPublic

Authored by benlangmuir on Jul 13 2022, 12:15 PM.

Details

Summary

While the inferred host triple for macOS is something like
<arch>-apple-darwin, it's also valid to have <arch>-apple-macos.
Currently that globally changes whether an SDKROOT is provided in tests,
so make this check more portable.

Diff Detail

Event Timeline

benlangmuir created this revision.Jul 13 2022, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 12:15 PM
Herald added a subscriber: delcypher. · View Herald Transcript
benlangmuir requested review of this revision.Jul 13 2022, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2022, 12:15 PM
akyrtzi accepted this revision.Jul 13 2022, 1:05 PM
This revision is now accepted and ready to land.Jul 13 2022, 1:05 PM
steven_wu accepted this revision.Jul 13 2022, 1:35 PM
This revision was landed with ongoing or failed builds.Jul 13 2022, 1:36 PM
This revision was automatically updated to reflect the committed changes.