This patch should fix the interactive crashlog test by checking in the
binary as a yaml to regeneate the binary with the addresses and offsets
when running the test.
rdar://93655633
Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Paths
| Differential D129603
[lldb/crashlog] Fix interactive crashlog test ClosedPublic Authored by mib on Jul 12 2022, 3:56 PM.
Details
Summary This patch should fix the interactive crashlog test by checking in the rdar://93655633 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
Diff Detail Event Timelinemib added a child revision: D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode.Jul 12 2022, 6:15 PM Comment Actions
Comment Actions Address @JDevlieghere feedback:
I'll get rid of patch-crashlog.py in a follow-up patch This revision is now accepted and ready to land.Aug 2 2022, 6:53 PM Closed by commit rG4c2fb2e551e0: [lldb/crashlog] Fix interactive crashlog test (authored by mib). · Explain WhyAug 9 2022, 4:33 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 449486 lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.cpp
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.yaml
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/multithread-test.cc
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/scripted_crashlog.ips
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/scripted_crashlog_json.test
|