This is an archive of the discontinued LLVM Phabricator instance.

Differential D129517

[libc] Add imaxabs
ClosedPublic

Authored by abrachet on Jul 11 2022, 2:22 PM.

Details

Reviewers
sivachandra
michaelrj
Commits
rGc179bcc15183: [libc] Add imaxabs

Diff Detail

Event Timeline

abrachet created this revision.Jul 11 2022, 2:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 2:22 PM
Herald added subscribers: ecnelises, tschuett, mgorny. · View Herald Transcript
abrachet requested review of this revision.Jul 11 2022, 2:22 PM
abrachet added a subscriber: libc-commits.
sivachandra accepted this revision.Jul 11 2022, 2:26 PM
This revision is now accepted and ready to land.Jul 11 2022, 2:26 PM
This revision was landed with ongoing or failed builds.Jul 11 2022, 2:28 PM
Closed by commit rGc179bcc15183: [libc] Add imaxabs (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
abrachet added a commit: rGc179bcc15183: [libc] Add imaxabs.
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2022, 2:28 PM
Harbormaster completed remote builds in B174745: Diff 443758.Jul 11 2022, 2:32 PM

Revision Contents

PathSize
libc/
config/
darwin/
arm/
1 line
linux/
aarch64/
1 line
arm/
1 line
x86_64/
1 line
windows/
1 line
src/
inttypes/
11 lines
20 lines
17 lines
test/
src/
inttypes/
14 lines
22 lines

Diff 443759

libc/config/darwin/arm/entrypoints.txt

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# string.h entrypoints that depend on malloc # string.h entrypoints that depend on malloc
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strndup libc.src.string.strndup
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxabs
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.atoi libc.src.stdlib.atoi
libc.src.stdlib.atof libc.src.stdlib.atof
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines

libc/config/linux/aarch64/entrypoints.txt

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# string.h entrypoints that depend on malloc # string.h entrypoints that depend on malloc
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strndup libc.src.string.strndup
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxabs
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.atoi libc.src.stdlib.atoi
libc.src.stdlib.atof libc.src.stdlib.atof
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines

libc/config/linux/arm/entrypoints.txt

Show All 33 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strpbrk libc.src.string.strpbrk
libc.src.string.strrchr libc.src.string.strrchr
libc.src.string.strspn libc.src.string.strspn
libc.src.string.strstr libc.src.string.strstr
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxabs
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.bsearch libc.src.stdlib.bsearch
libc.src.stdlib.div libc.src.stdlib.div
Show All 14 Lines

libc/config/linux/x86_64/entrypoints.txt

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# string.h entrypoints that depend on malloc # string.h entrypoints that depend on malloc
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strndup libc.src.string.strndup
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxabs
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.atoi libc.src.stdlib.atoi
libc.src.stdlib.atof libc.src.stdlib.atof
▲ Show 20 Lines • Show All 258 Lines • Show Last 20 Lines

libc/config/windows/entrypoints.txt

Show First 20 Lines • Show All 48 Lines • ▼ Show 20 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.string.strtok libc.src.string.strtok
libc.src.string.strtok_r libc.src.string.strtok_r
# string.h entrypoints that depend on malloc # string.h entrypoints that depend on malloc
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strndup libc.src.string.strndup
# inttypes.h entrypoints # inttypes.h entrypoints
libc.src.inttypes.imaxabs
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
libc.src.inttypes.strtoimax libc.src.inttypes.strtoimax
libc.src.inttypes.strtoumax libc.src.inttypes.strtoumax
# stdlib.h entrypoints # stdlib.h entrypoints
libc.src.stdlib.abs libc.src.stdlib.abs
libc.src.stdlib.atoi libc.src.stdlib.atoi
libc.src.stdlib.atof libc.src.stdlib.atof
▲ Show 20 Lines • Show All 141 Lines • Show Last 20 Lines

libc/src/inttypes/CMakeLists.txt

Show All 22 Linesadd_entrypoint_object(
SRCS SRCS
imaxdiv.cpp imaxdiv.cpp
HDRS HDRS
imaxdiv.h imaxdiv.h
DEPENDS DEPENDS
libc.include.inttypes libc.include.inttypes
libc.src.__support.integer_operations libc.src.__support.integer_operations
) )
add_entrypoint_object(
imaxabs
SRCS
imaxabs.cpp
HDRS
imaxabs.h
DEPENDS
libc.include.inttypes
libc.src.__support.integer_operations
)

libc/src/inttypes/imaxabs.h

  • This file was added.
//===-- Implementation header for imaxabs -----------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef LLVM_LIBC_SRC_INTTYPES_IMAXABS_H
#define LLVM_LIBC_SRC_INTTYPES_IMAXABS_H
#include <inttypes.h>
namespace __llvm_libc {
intmax_t imaxabs(intmax_t j);
} // namespace __llvm_libc
#endif // LLVM_LIBC_SRC_INTTYPES_IMAXABS_H

libc/src/inttypes/imaxabs.cpp

  • This file was added.
//===-- Implementation of imaxabs -----------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/inttypes/imaxabs.h"
#include "src/__support/common.h"
#include "src/__support/integer_operations.h"
namespace __llvm_libc {
LLVM_LIBC_FUNCTION(intmax_t, imaxabs, (intmax_t j)) { return integer_abs(j); }
} // namespace __llvm_libc

libc/test/src/inttypes/CMakeLists.txt

Show All 26 Linesadd_libc_unittest(
SRCS SRCS
imaxdiv_test.cpp imaxdiv_test.cpp
HDRS HDRS
../stdlib/DivTest.h ../stdlib/DivTest.h
DEPENDS DEPENDS
libc.include.stdlib libc.include.stdlib
libc.src.inttypes.imaxdiv libc.src.inttypes.imaxdiv
) )
add_libc_unittest(
imaxabs_test
SUITE
libc_inttypes_unittests
SRCS
imaxabs_test.cpp
HDRS
../stdlib/DivTest.h
DEPENDS
libc.include.stdlib
libc.src.inttypes.imaxabs
)

libc/test/src/inttypes/imaxabs_test.cpp

  • This file was added.
//===-- Unittests for imaxabs ---------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "src/inttypes/imaxabs.h"
#include "utils/UnitTest/Test.h"
TEST(LlvmLibcImaxAbsTest, Zero) {
EXPECT_EQ(__llvm_libc::imaxabs(0), intmax_t(0));
}
TEST(LlvmLibcImaxAbsTest, Positive) {
EXPECT_EQ(__llvm_libc::imaxabs(1), intmax_t(1));
}
TEST(LlvmLibcImaxAbsTest, Negative) {
EXPECT_EQ(__llvm_libc::imaxabs(-1), intmax_t(1));
}