Page MenuHomePhabricator

[libc++] Simplify __config a bit more and add underscores to attributes
ClosedPublic

Authored by philnik on Jul 10 2022, 4:09 PM.

Diff Detail

Event Timeline

philnik created this revision.Jul 10 2022, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2022, 4:09 PM
philnik requested review of this revision.Jul 10 2022, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2022, 4:09 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 4 2022, 8:25 AM

Typo in commit message. Also, you might want to say "add underscores to attribute names" just to clarify.

libcxx/include/__config
712

I would like to keep the definition of _LIBCPP_DECLARE_STRONG_ENUM[_EPILOG] the way it was. I think it makes sense for simple things like decltype and static_assert to be bulk-declared like you do above (in the new patch), but for more complicated things like this, it just obscures things out.

This revision is now accepted and ready to land.Aug 4 2022, 8:25 AM
philnik retitled this revision from [libc++] Simplify __config a bit more and add undersocres to [libc++] Simplify __config a bit more and add underscores to attributes.Aug 9 2022, 4:10 AM
philnik updated this revision to Diff 451102.Aug 9 2022, 4:22 AM
philnik marked an inline comment as done.
  • Address comments