This is an archive of the discontinued LLVM Phabricator instance.

Update sanitize_* IR documentation.
ClosedPublic

Authored by hctim on Jul 8 2022, 4:43 PM.

Details

Summary

sanitize_none was never actually committed, and should be removed.

no_sanitize_memtag is to be removed in D128950.

sanitize_memtag is new in D128950.

Also update the comments on other no_sanitize_* to indicate that they're
impacted by the sanitizer ignorelist and the global-disable attribute.

Diff Detail

Event Timeline

hctim created this revision.Jul 8 2022, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 4:43 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
hctim requested review of this revision.Jul 8 2022, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2022, 4:43 PM
eugenis accepted this revision.Jul 12 2022, 4:48 PM

LGTM

llvm/docs/LangRef.rst
2349

"as long as the attribute" - as long as the global

2353

"when it's not possible to be tagged" - missing "global" somewhere?

This revision is now accepted and ready to land.Jul 12 2022, 4:48 PM
hctim updated this revision to Diff 444112.Jul 12 2022, 5:00 PM
hctim marked 2 inline comments as done.

Update w/ Evgenii's suggestions.

This revision was landed with ongoing or failed builds.Jul 13 2022, 8:55 AM
This revision was automatically updated to reflect the committed changes.