This is an archive of the discontinued LLVM Phabricator instance.

[libc] add dependencies to generic sqrt tests
ClosedPublic

Authored by michaelrj on Jul 8 2022, 11:36 AM.

Details

Summary

This adds dependencies on the corresponding sqrt function to each
generic sqrt test. This is so that on platforms that don't support the
math functions, the tests are not run.

Diff Detail

Event Timeline

michaelrj created this revision.Jul 8 2022, 11:36 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 8 2022, 11:36 AM
michaelrj requested review of this revision.Jul 8 2022, 11:36 AM
lntue accepted this revision.Jul 8 2022, 11:52 AM
This revision is now accepted and ready to land.Jul 8 2022, 11:52 AM
This revision was automatically updated to reflect the committed changes.

IMHO, this is not correct - you are introducing an artificial dependency and your expectation will break in future when sqrt functions are actually available say via inline assembly. You should rather just disable these tests for targets they are not ready for.