This is an archive of the discontinued LLVM Phabricator instance.

Differential D129341

[mlir][complex] Lower complex.angle to libm
ClosedPublic

Authored by Lewuathe on Jul 7 2022, 7:24 PM.

Details

Reviewers
pifon2a
bixia
Commits
rGf27deeee7914: [mlir][complex] Lower complex.angle to libm
Summary

complex.angle corresponds to arg function in libm. We can lower complex.angle to arg and argf.

Diff Detail

Event Timeline

Lewuathe created this revision.Jul 7 2022, 7:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 7:24 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
Lewuathe requested review of this revision.Jul 7 2022, 7:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 7:24 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
pifon2a accepted this revision.Jul 7 2022, 7:29 PM
This revision is now accepted and ready to land.Jul 7 2022, 7:29 PM
This revision was landed with ongoing or failed builds.Jul 7 2022, 7:39 PM
Closed by commit rGf27deeee7914: [mlir][complex] Lower complex.angle to libm (authored by Lewuathe, committed by pifon2a). · Explain Why
This revision was automatically updated to reflect the committed changes.
pifon2a added a commit: rGf27deeee7914: [mlir][complex] Lower complex.angle to libm.
Harbormaster completed remote builds in B174292: Diff 443113.Jul 7 2022, 7:49 PM

Revision Contents

PathSize
mlir/
lib/
Conversion/
ComplexToLibm/
4 lines
test/
Conversion/
ComplexToLibm/
12 lines

Diff 443118

mlir/lib/Conversion/ComplexToLibm/ComplexToLibm.cpp

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Linesvoid mlir::populateComplexToLibmConversionPatterns(RewritePatternSet &patterns,
patterns.add<ScalarOpToLibmCall<complex::CosOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::CosOp>>(patterns.getContext(),
"ccosf", "ccos", benefit); "ccosf", "ccos", benefit);
patterns.add<ScalarOpToLibmCall<complex::SinOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::SinOp>>(patterns.getContext(),
"csinf", "csin", benefit); "csinf", "csin", benefit);
patterns.add<ScalarOpToLibmCall<complex::ConjOp>>(patterns.getContext(), patterns.add<ScalarOpToLibmCall<complex::ConjOp>>(patterns.getContext(),
"conjf", "conj", benefit); "conjf", "conj", benefit);
patterns.add<ScalarOpToLibmCall<complex::AbsOp, FloatTypeResolver>>( patterns.add<ScalarOpToLibmCall<complex::AbsOp, FloatTypeResolver>>(
patterns.getContext(), "cabsf", "cabs", benefit); patterns.getContext(), "cabsf", "cabs", benefit);
patterns.add<ScalarOpToLibmCall<complex::AngleOp, FloatTypeResolver>>(
patterns.getContext(), "cargf", "carg", benefit);
} }
namespace { namespace {
struct ConvertComplexToLibmPass struct ConvertComplexToLibmPass
: public ConvertComplexToLibmBase<ConvertComplexToLibmPass> { : public ConvertComplexToLibmBase<ConvertComplexToLibmPass> {
void runOnOperation() override; void runOnOperation() override;
}; };
} // namespace } // namespace
void ConvertComplexToLibmPass::runOnOperation() { void ConvertComplexToLibmPass::runOnOperation() {
auto module = getOperation(); auto module = getOperation();
RewritePatternSet patterns(&getContext()); RewritePatternSet patterns(&getContext());
populateComplexToLibmConversionPatterns(patterns, /*benefit=*/1); populateComplexToLibmConversionPatterns(patterns, /*benefit=*/1);
ConversionTarget target(getContext()); ConversionTarget target(getContext());
target.addLegalDialect<func::FuncDialect>(); target.addLegalDialect<func::FuncDialect>();
target.addIllegalOp<complex::PowOp, complex::SqrtOp, complex::TanhOp, target.addIllegalOp<complex::PowOp, complex::SqrtOp, complex::TanhOp,
complex::AbsOp>(); complex::AbsOp, complex::AngleOp>();
if (failed(applyPartialConversion(module, target, std::move(patterns)))) if (failed(applyPartialConversion(module, target, std::move(patterns))))
signalPassFailure(); signalPassFailure();
} }
std::unique_ptr<OperationPass<ModuleOp>> std::unique_ptr<OperationPass<ModuleOp>>
mlir::createConvertComplexToLibmPass() { mlir::createConvertComplexToLibmPass() {
return std::make_unique<ConvertComplexToLibmPass>(); return std::make_unique<ConvertComplexToLibmPass>();
} }

mlir/test/Conversion/ComplexToLibm/convert-to-libm.mlir

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines
// CHECK-SAME: %[[DOUBLE:.*]]: complex<f64> // CHECK-SAME: %[[DOUBLE:.*]]: complex<f64>
func.func @cabs_caller(%float: complex<f32>, %double: complex<f64>) -> (f32, f64) { func.func @cabs_caller(%float: complex<f32>, %double: complex<f64>) -> (f32, f64) {
// CHECK: %[[FLOAT_RESULT:.*]] = call @cabsf(%[[FLOAT]]) // CHECK: %[[FLOAT_RESULT:.*]] = call @cabsf(%[[FLOAT]])
%float_result = complex.abs %float : complex<f32> %float_result = complex.abs %float : complex<f32>
// CHECK: %[[DOUBLE_RESULT:.*]] = call @cabs(%[[DOUBLE]]) // CHECK: %[[DOUBLE_RESULT:.*]] = call @cabs(%[[DOUBLE]])
%double_result = complex.abs %double : complex<f64> %double_result = complex.abs %double : complex<f64>
// CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]] // CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]]
return %float_result, %double_result : f32, f64 return %float_result, %double_result : f32, f64
}
// CHECK-LABEL: func @carg_caller
// CHECK-SAME: %[[FLOAT:.*]]: complex<f32>
// CHECK-SAME: %[[DOUBLE:.*]]: complex<f64>
func.func @carg_caller(%float: complex<f32>, %double: complex<f64>) -> (f32, f64) {
// CHECK: %[[FLOAT_RESULT:.*]] = call @cargf(%[[FLOAT]])
%float_result = complex.angle %float : complex<f32>
// CHECK: %[[DOUBLE_RESULT:.*]] = call @carg(%[[DOUBLE]])
%double_result = complex.angle %double : complex<f64>
// CHECK: return %[[FLOAT_RESULT]], %[[DOUBLE_RESULT]]
return %float_result, %double_result : f32, f64
} }
No newline at end of file No newline at end of file