This is an archive of the discontinued LLVM Phabricator instance.

[hwasan][fuchsia] Fix features bitmask checking
ClosedPublic

Authored by leonardchan on Jul 7 2022, 12:00 PM.

Details

Summary

Update the address tagging bitmask check to just see if ZX_ARM64_FEATURE_ADDRESS_TAGGING_TBI is enabled rather than checking if it's the only thing that's enabled.

Diff Detail

Event Timeline

leonardchan created this revision.Jul 7 2022, 12:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 12:00 PM
mcgrathr accepted this revision.Jul 7 2022, 12:12 PM

lgtm

compiler-rt/lib/hwasan/hwasan_fuchsia.cpp
195–196

It might be clearer to just say requires ZX_ARM64_FEATURE_ADDRESS_TAGGING_TBI here.

This revision is now accepted and ready to land.Jul 7 2022, 12:12 PM
This revision was landed with ongoing or failed builds.Jul 7 2022, 2:43 PM
This revision was automatically updated to reflect the committed changes.
leonardchan marked an inline comment as done.