This is an archive of the discontinued LLVM Phabricator instance.

[AVR] Remove debug location of spill/reload instructions
ClosedPublic

Authored by Miss_Grape on Jul 7 2022, 1:34 AM.

Diff Detail

Event Timeline

Miss_Grape created this revision.Jul 7 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 1:34 AM
Herald added subscribers: Jim, hiraditya. · View Herald Transcript
Miss_Grape requested review of this revision.Jul 7 2022, 1:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2022, 1:34 AM
MatzeB added a comment.Jul 7 2022, 9:30 AM

I'm probably the wrong reviewer for the AVR target. But I agree that spills/reload instructions are compiler-generated without relation to the source-code being compiled and would be better off without debug locations.

MatzeB accepted this revision.Jul 7 2022, 9:31 AM

This change is straightforward enough. LGTM

This revision is now accepted and ready to land.Jul 7 2022, 9:31 AM
benshi001 accepted this revision.Jul 7 2022, 7:56 PM
This revision was landed with ongoing or failed builds.Aug 13 2022, 5:58 AM
This revision was automatically updated to reflect the committed changes.