[mlir][interfaces][NFC] Remove ViewLikeInterface::expandToRank

[springerm]

Summary

This helper function is no longer needed.

Depends On D129144

[springerm]

update

[springerm]

update

mlir/include/mlir/Interfaces/ViewLikeInterface.td

let extraClassDeclaration = [{
     }
     static ::llvm::ArrayRef<::llvm::StringRef> getSpecialAttrNames() {
       static ::llvm::SmallVector<::llvm::StringRef, 4> names{
         ::mlir::OffsetSizeAndStrideOpInterface::getStaticOffsetsAttrName(),
         ::mlir::OffsetSizeAndStrideOpInterface::getStaticSizesAttrName(),
         ::mlir::OffsetSizeAndStrideOpInterface::getStaticStridesAttrName(),
         ::mlir::OpTrait::AttrSizedOperandSegments<void>::getOperandSegmentSizeAttr()};
       return names;
     }
-   /// Assume target is a shaped type and offsets/sizes/strides are vectors of
-   /// the same length and lower than target's rank.
-   /// Complete missing dims `i` with offset=0, size=dim(target, i), stride=1
-   /// until all vectors have size rank. The commpletion occurs for the most
-   /// minor dimensions (i.e. fastest varying).
-   /// Take a `createDim` lambda that knows how to build the size of a
-   /// particular dimension of `target` (to avoid dialect dependencies).
-   static void expandToRank(
-     Value target,
-     SmallVector<OpFoldResult> &offsets,
-     SmallVector<OpFoldResult> &sizes,
-     SmallVector<OpFoldResult> &strides,
-     llvm::function_ref<OpFoldResult(Value, int64_t)> createDim);
   }];
 
   let verify = [{
     return ::mlir::detail::verifyOffsetSizeAndStrideOp(
         ::mlir::cast<::mlir::OffsetSizeAndStrideOpInterface>($_op));
   }];
 }
 
 #endif // MLIR_INTERFACES_VIEWLIKEINTERFACE

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp

Type SubViewOp::inferRankReducedResultType(ArrayRef<int64_t> resultShape,
   unsigned resultIdx = 0, inferredIdx = 0;
   while (resultIdx < resultShape.size()) {
     if (inferredShape[inferredIdx] == resultShape[resultIdx]) {
       ++resultIdx;
       ++inferredIdx;
       continue;
     }
     // Drop this dimension.
+    assert(inferredShape[inferredIdx] == 1 && "invalid rank reduction");
     dimsToProject.set(inferredIdx);
     ++inferredIdx;
   }
   // Drop all remaining dimensions.
   for (unsigned idx = inferredIdx; idx < inferredShape.size(); ++idx) {
     assert(inferredShape[idx] == 1 && "invalid rank reduction");
     dimsToProject.set(idx);
   }

mlir/lib/Interfaces/ViewLikeInterface.cpp

for (auto it : llvm::zip(a.getMixedSizes(), b.getMixedSizes()))
     if (!cmp(std::get<0>(it), std::get<1>(it)))
       return false;
   for (auto it : llvm::zip(a.getMixedStrides(), b.getMixedStrides()))
     if (!cmp(std::get<0>(it), std::get<1>(it)))
       return false;
   return true;
 }
 
-void OffsetSizeAndStrideOpInterface::expandToRank(
-    Value target, SmallVector<OpFoldResult> &offsets,
-    SmallVector<OpFoldResult> &sizes, SmallVector<OpFoldResult> &strides,
-    llvm::function_ref<OpFoldResult(Value, int64_t)> createOrFoldDim) {
-  auto shapedType = target.getType().cast<ShapedType>();
-  unsigned rank = shapedType.getRank();
-  assert(offsets.size() == sizes.size() && "mismatched lengths");
-  assert(offsets.size() == strides.size() && "mismatched lengths");
-  assert(offsets.size() <= rank && "rank overflow");
-  MLIRContext *ctx = target.getContext();
-  Attribute zero = IntegerAttr::get(IndexType::get(ctx), APInt(64, 0));
-  Attribute one = IntegerAttr::get(IndexType::get(ctx), APInt(64, 1));
-  for (unsigned i = offsets.size(); i < rank; ++i) {
-    offsets.push_back(zero);
-    sizes.push_back(createOrFoldDim(target, i));
-    strides.push_back(one);
-  }
-}
-
 SmallVector<OpFoldResult, 4>
 mlir::getMixedOffsets(OffsetSizeAndStrideOpInterface op,
                       ArrayAttr staticOffsets, ValueRange offsets) {
   SmallVector<OpFoldResult, 4> res;
   unsigned numDynamic = 0;
   unsigned count = static_cast<unsigned>(staticOffsets.size());
   for (unsigned idx = 0; idx < count; ++idx) {
     if (op.isDynamicOffset(idx))