This is an archive of the discontinued LLVM Phabricator instance.

	Show First 20 Lines • Show All 408 Lines • ▼ Show 20 Lines

	/// Given an extract element instruction with constant index operand, shuffle			/// Given an extract element instruction with constant index operand, shuffle
	/// the source vector (shift the scalar element) to a NewIndex for extraction.			/// the source vector (shift the scalar element) to a NewIndex for extraction.
	/// Return null if the input can be constant folded, so that we are not creating			/// Return null if the input can be constant folded, so that we are not creating
	/// unnecessary instructions.			/// unnecessary instructions.
	static ExtractElementInst translateExtract(ExtractElementInst ExtElt,			static ExtractElementInst translateExtract(ExtractElementInst ExtElt,
	unsigned NewIndex,			unsigned NewIndex,
	IRBuilder<> &Builder) {			IRBuilder<> &Builder) {
				// Shufflevectors can only be created for fixed-width vectors.
				if (!isa<FixedVectorType>(ExtElt->getOperand(0)->getType()))
				return nullptr;

	// If the extract can be constant-folded, this code is unsimplified. Defer			// If the extract can be constant-folded, this code is unsimplified. Defer
	// to other passes to handle that.			// to other passes to handle that.
	Value *X = ExtElt->getVectorOperand();			Value *X = ExtElt->getVectorOperand();
	Value *C = ExtElt->getIndexOperand();			Value *C = ExtElt->getIndexOperand();
	assert(isa<ConstantInt>(C) && "Expected a constant index operand");			assert(isa<ConstantInt>(C) && "Expected a constant index operand");
	if (isa<Constant>(X))			if (isa<Constant>(X))
	return nullptr;			return nullptr;

	▲ Show 20 Lines • Show All 1,245 Lines • Show Last 20 Lines

llvm/test/Transforms/VectorCombine/AArch64/extract-scalable.ll

	Show All 14 Lines
	;			;
	%e1 = extractelement <vscale x 4 x i32> %a, i32 3			%e1 = extractelement <vscale x 4 x i32> %a, i32 3
	%e2 = extractelement <vscale x 4 x i32> %a, i32 1			%e2 = extractelement <vscale x 4 x i32> %a, i32 1
	%cmp1 = icmp sgt i32 %e1, 42			%cmp1 = icmp sgt i32 %e1, 42
	%cmp2 = icmp sgt i32 %e2, -8			%cmp2 = icmp sgt i32 %e2, -8
	%r = xor i1 %cmp1, %cmp2			%r = xor i1 %cmp1, %cmp2
	ret i1 %r			ret i1 %r
	}			}

				; Test that VectorCombine doesn't try to create a shufflevector for
				fhahnUnsubmitted Done Reply Inline Actions Could you add a quick comment describing what this tests and a reference to the issue? fhahn: Could you add a quick comment describing what this tests and a reference to the issue?
				; an extract-extract pattern on a scalable vector type.
				define i32 @extract_extract(<vscale x 4 x i32> %vec) {
				; CHECK-LABEL: @extract_extract(
				; CHECK-NEXT: [[ELT0:%.]] = extractelement <vscale x 4 x i32> [[VEC:%.]], i32 0
				; CHECK-NEXT: [[ELT1:%.*]] = extractelement <vscale x 4 x i32> [[VEC]], i32 1
				; CHECK-NEXT: [[IDX:%.*]] = add i32 [[ELT0]], [[ELT1]]
				; CHECK-NEXT: [[ELTIDX:%.*]] = extractelement <vscale x 4 x i32> [[VEC]], i32 [[IDX]]
				; CHECK-NEXT: ret i32 [[ELTIDX]]
				;
				%elt0 = extractelement <vscale x 4 x i32> %vec, i32 0
				%elt1 = extractelement <vscale x 4 x i32> %vec, i32 1
				%idx = add i32 %elt0, %elt1
				%eltidx = extractelement <vscale x 4 x i32> %vec, i32 %idx
				ret i32 %eltidx;
				}

This is an archive of the discontinued LLVM Phabricator instance.

[VectorCombine] Avoid creating shuffle for extract-extract pattern on scalable vector.ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 442818

llvm/lib/Transforms/Vectorize/VectorCombine.cpp

llvm/test/Transforms/VectorCombine/AArch64/extract-scalable.ll

[VectorCombine] Avoid creating shuffle for extract-extract pattern on scalable vector.
ClosedPublic