This is an archive of the discontinued LLVM Phabricator instance.

Differential D129101

[mlir][sparse]Replace redundant indices checks in sparse_tensor.conversion
ClosedPublic

Authored by anlunx on Jul 4 2022, 5:41 PM.

Details

Reviewers
aartbik
Commits
rG033b9f21b00b: [mlir][sparse]Replace redundant indices checks in sparse_tensor.conversion
Summary

Replace some redundant indices checks with the correct checks

Diff Detail

Event Timeline

anlunx created this revision.Jul 4 2022, 5:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2022, 5:41 PM
Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui and 18 others. · View Herald Transcript
anlunx requested review of this revision.Jul 4 2022, 5:41 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptJul 4 2022, 5:41 PM
Harbormaster completed remote builds in B173612: Diff 442158.Jul 4 2022, 6:07 PM
aartbik accepted this revision.Jul 6 2022, 10:30 AM

Excellent catch. Thanks for fixing!

This revision is now accepted and ready to land.Jul 6 2022, 10:30 AM
anlunx added a comment.Jul 6 2022, 4:07 PM
In D129101#3633389, @aartbik wrote:

Excellent catch. Thanks for fixing!

Hi Aart, would you be able to submit this change for me? I think I currently don't have the commit access.

Closed by commit rG033b9f21b00b: [mlir][sparse]Replace redundant indices checks in sparse_tensor.conversion (authored by anlunx). · Explain WhyJul 12 2022, 9:04 PM
This revision was automatically updated to reflect the committed changes.
anlunx added a commit: rG033b9f21b00b: [mlir][sparse]Replace redundant indices checks in sparse_tensor.conversion.

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
SparseTensor/
CPU/
24 lines

Diff 444146

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conversion.mlir

Show First 20 Lines • Show All 128 Lines • ▼ Show 20 Lines func.func @entry() {
call @dumpf64(%iv) : (memref<?xf64>) -> () call @dumpf64(%iv) : (memref<?xf64>) -> ()
// //
// Check indices. // Check indices.
// //
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 ) // CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 )
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 ) // CHECK-NEXT: ( 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0 )
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 0, 1, 0, 1, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 1, 2, 0, 1, 2, 0, 1, 2, 0, 1, 2, 0, 1, 2, 0, 1, 2, 0 )
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 ) // CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 )
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 ) // CHECK-NEXT: ( 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0, 1, 2, 3, 0 )
// CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
// CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 ) // CHECK-NEXT: ( 0, 1, 2, 0, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 )
▲ Show 20 Lines • Show All 55 Lines • ▼ Show 20 Lines func.func @entry() {
%h32 = sparse_tensor.indices %h, %c2 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex> %h32 = sparse_tensor.indices %h, %c2 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex>
%i30 = sparse_tensor.indices %i, %c0 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex> %i30 = sparse_tensor.indices %i, %c0 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex>
%i31 = sparse_tensor.indices %i, %c1 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex> %i31 = sparse_tensor.indices %i, %c1 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex>
%i32 = sparse_tensor.indices %i, %c2 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex> %i32 = sparse_tensor.indices %i, %c2 : tensor<2x3x4xf64, #Tensor3> to memref<?xindex>
call @dumpidx(%v10) : (memref<?xindex>) -> () call @dumpidx(%v10) : (memref<?xindex>) -> ()
call @dumpidx(%v11) : (memref<?xindex>) -> () call @dumpidx(%v11) : (memref<?xindex>) -> ()
call @dumpidx(%v12) : (memref<?xindex>) -> () call @dumpidx(%v12) : (memref<?xindex>) -> ()
call @dumpidx(%v10) : (memref<?xindex>) -> () call @dumpidx(%v20) : (memref<?xindex>) -> ()
call @dumpidx(%v11) : (memref<?xindex>) -> () call @dumpidx(%v21) : (memref<?xindex>) -> ()
call @dumpidx(%v12) : (memref<?xindex>) -> () call @dumpidx(%v22) : (memref<?xindex>) -> ()
call @dumpidx(%v10) : (memref<?xindex>) -> () call @dumpidx(%v30) : (memref<?xindex>) -> ()
call @dumpidx(%v11) : (memref<?xindex>) -> () call @dumpidx(%v31) : (memref<?xindex>) -> ()
call @dumpidx(%v12) : (memref<?xindex>) -> () call @dumpidx(%v32) : (memref<?xindex>) -> ()
call @dumpidx(%a10) : (memref<?xindex>) -> () call @dumpidx(%a10) : (memref<?xindex>) -> ()
call @dumpidx(%a11) : (memref<?xindex>) -> () call @dumpidx(%a11) : (memref<?xindex>) -> ()
call @dumpidx(%a12) : (memref<?xindex>) -> () call @dumpidx(%a12) : (memref<?xindex>) -> ()
call @dumpidx(%b10) : (memref<?xindex>) -> () call @dumpidx(%b10) : (memref<?xindex>) -> ()
call @dumpidx(%b11) : (memref<?xindex>) -> () call @dumpidx(%b11) : (memref<?xindex>) -> ()
call @dumpidx(%b12) : (memref<?xindex>) -> () call @dumpidx(%b12) : (memref<?xindex>) -> ()
call @dumpidx(%c10) : (memref<?xindex>) -> () call @dumpidx(%c10) : (memref<?xindex>) -> ()
Show All 37 Lines